-
Notifications
You must be signed in to change notification settings - Fork 5.6k
fix: show toast error message on ConfigMarkdown parse error #8049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
fix: show toast error message on ConfigMarkdown parse error #8049
Conversation
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
|
/review |
|
can u tweak it to match the rest of our style, avoid try catch use .catch instead |
sure, let me have a closer look |
|
@rekram1-node should be good now - my python brain went try...catch first hehe |
tenlisboa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are repeating the same code in 3 different places, why not create a single helper function to perform this and import/use instead?
|
@tenlisboa it was flagged up with automated github-actions review, but @rekram1-node closed that comment with "nah" 😄 - check above |
What does this PR do?
Fixes #8047
This fixes issue #8047 by wrapping
ConfigMarkdown.parse()calls intry...catchand displaying appropriate error messages in form of toast