Skip to content

Conversation

@vvarp
Copy link

@vvarp vvarp commented Jan 12, 2026

What does this PR do?

Fixes #8047

This fixes issue #8047 by wrapping ConfigMarkdown.parse() calls in try...catch and displaying appropriate error messages in form of toast

@github-actions
Copy link
Contributor

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

@github-actions
Copy link
Contributor

The following comment was made by an LLM, it may be inaccurate:

No duplicate PRs found

@vvarp vvarp changed the title fix: show toast error message on ConfigMarkdown parse error fix: show toast error message on ConfigMarkdown parse error (Fixes #8047) Jan 12, 2026
@vvarp vvarp changed the title fix: show toast error message on ConfigMarkdown parse error (Fixes #8047) fix: show toast error message on ConfigMarkdown parse error Jan 12, 2026
@rekram1-node
Copy link
Collaborator

/review

@rekram1-node
Copy link
Collaborator

can u tweak it to match the rest of our style, avoid try catch use .catch instead

@vvarp
Copy link
Author

vvarp commented Jan 12, 2026

can u tweak it to match the rest of our style, avoid try catch use .catch instead

sure, let me have a closer look

@vvarp
Copy link
Author

vvarp commented Jan 12, 2026

@rekram1-node should be good now - my python brain went try...catch first hehe

@vvarp vvarp requested a review from rekram1-node January 12, 2026 19:08
Copy link

@tenlisboa tenlisboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are repeating the same code in 3 different places, why not create a single helper function to perform this and import/use instead?

@vvarp
Copy link
Author

vvarp commented Jan 12, 2026

@tenlisboa it was flagged up with automated github-actions review, but @rekram1-node closed that comment with "nah" 😄 - check above

@vvarp vvarp requested a review from tenlisboa January 12, 2026 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

YAML parsing errors in skills/agents cause TUI crashes

3 participants