Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rift cannot safely review and recover a lifecycle change before removing a snapshot. This adds an opt-in guarded command group that binds a plan to exact registry, marker, filesystem and build state, moves selected snapshots to adjacent native trash, and records recoverable lifecycle journals. Existing lifecycle commands remain available.
The change adds preflight, apply, finalize, recover and strict rollback for path reconciliation and trash operations. Fixture-only fault injection is gated from production builds. It includes source documentation, failure-mode coverage and an executable E2E harness.
Validation on macOS/APFS: 59 fixture E2E scenarios, production lifecycle E2E, 80 workspace tests, formatting and Clippy passed. The unchanged production code also completed six real apply/finalize pairs. Linux runtime E2E has not been run. Legacy callers must be quiesced; strict rollback refuses later state drift. Unconfirmed postremove completion blocks finalization.
Draft for upstream review. No merge requested.