fix(build): green staging tsc + declare phantom expo native deps#102
Merged
Conversation
Staging tsc is red: NetworkModeContext still passes the pre-anonmesh#81 beaconRpcWait name, but MeshRpcAdapter takes beaconBroadcastRpc since the link-protocol migration. Use the hook value already destructured in this component. Unblocks the tier0 gate.
expo install --check fails the tier0 gate on clean staging (expo-font 14.0.11 -> ~14.0.12, expo-router 6.0.23 -> ~6.0.24).
LxmfContext imports expo-file-system/legacy but the package was only present as a transitive dep of expo core; the 54.0.35 bump dropped it from the graph, breaking tsc and silently omitting the native module from new builds.
babel.config.js references babel-preset-expo by name but it was only nested under expo/node_modules — any lockfile regen breaks Metro at the root. The tier0 fake-money/secret scans run rg inside if-conditions, so a missing binary passed them vacuously; fail loudly instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of the night3 lane PRs — foundational, unblocks tsc/CI for the others.
What
context/NetworkModeContext.tsx:110/112passedbeaconRpcWait(never destructured into scope) toMeshRpcAdapterinstead of the already-in-scopebeaconBroadcastRpc(destructured at :64). Half-finished rename. 2-line caller fix — touches no adapter/transport code.expo-file-system+babel-preset-expoexisted only transitively; a lock regen dropped them and one build produced an APK missing the expo-file-system native module (runtime crash at LxmfContext init). Both now direct deps with SDK-expected patch pins.rgwas absent (if rg …swallowed exit-127 → fake-money/secret scans silently passed). Script now requires rg.Scope
5 files:
NetworkModeContext.tsx(2 lines),package.json,package-lock.json,app.json,scripts/validate-tier0.sh. No adapter / lxmf / transport files.Test
tier0 all 10 sections green on the integrated branch (local).
Watch
package-lock.jsonregenerated 3 days ago; the v3 lockfile fix (--legacy-peer-deps, 25h ago) isn't on staging yet — if CI enforces that flag, this lock may need a regen on the staging base.