Fix asset scan result aggregation - #20
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Root cause
The scanner correctly scanned each resolved address, but the API counted each per-address observation as a separate service and the frontend flattened all host rows. A hostname with four CDN addresses therefore displayed four copies of ports 80 and 443.
User impact
Threat Radar now reports the logical exposure once while preserving the underlying endpoint evidence for analyst review. Existing saved scans are also rendered without duplicate rows.
Validation
python -m pytest -q -o addopts='' tests/unit/test_asset_vulnerability_scanner.py— 12 passed