Fix: Properly format --build-arg values in Podman image build task#306
Open
GSSparks wants to merge 3 commits intoansible-community:mainfrom
Open
Fix: Properly format --build-arg values in Podman image build task#306GSSparks wants to merge 3 commits intoansible-community:mainfrom
GSSparks wants to merge 3 commits intoansible-community:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: This PR fixes an issue in the Molecule playbook where Podman build arguments were not being separated by whitespace, causing command-line parsing errors when passing complex values (e.g. values containing --dns, environment substitutions, etc.).
Problem: The original extra_args Jinja2 block rendered build arguments like this:
--build-arg=FOO=BAR --dns=1.2.3.4--build-arg=BAR=bazBecause there were no spaces between build arguments generated in the loop, arguments would be concatenated incorrectly, breaking the podman build command.
Fix: The fix uses Ansible's zip_longest filter to format
--build-arg=KEY=VALUEstrings cleanly and space-separated. This ensures that each argument is properly delimited, even when values contain CLI-like content.