fix: openstack driver private address retrieval when auto_ip is False (ansible 2.19)#326
Open
ednxzu wants to merge 7 commits intoansible-community:mainfrom
Open
Conversation
ednxzu
force-pushed
the
fix/openstack-private-address-conditional
branch
from
0208aab to
beafd54
Compare
|
Label error. Requires exactly 1 of: breaking, chore, feat, fix. Found: . Follow https://www.conventionalcommits.org to get auto-labeling to work correctly. |
Author
|
Not sure about the current error, but it seems like this PR is missing a label ? |
Author
|
Any news on this ? |
Author
|
up |
Author
|
anyone cares to have a look at this ? |
In ansible 2.19, the template for retrieving the public(floating) address of a molecule instance returns a NoneType value, which in turn evaluates to False when compared to , which cause the private address of the instance to never get picker up as fallback. This commit changes the condition to not address | bool which in both case will evaluate to True if the retrieval of the public ip failed.
ansible-community#358) * fix(devel): drop --driver-name from init scenario, patch molecule.yml for Molecule 4.x Made-with: Cursor * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * linting fixes * force pipeline to re-run due to timeout on last job * revert dict sort back * XFAIL fixes? * fix role init * remove linting not needed * remove --role-name * fix docker test? * docker fixes --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
ednxzu
force-pushed
the
fix/openstack-private-address-conditional
branch
from
1bb64cb to
6a828ab
Compare
Author
|
oh no there was a merge I didn't see... whoops |
|
Oops, apologies! It seems my fix changing Git history was not the problem. I was following https://www.conventionalcommits.org/en/v1.0.0/#summary. Now that I reread the error, I wonder if you might need to update your PR title to use the 'fix:' label, as with other PRs in the repo? |
ednxzu
changed the title
Author
|
@BenjaminCarpenter480 it looks like it's missing a label but I can't seems to be able to add one myself |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In ansible 2.19, the template for retrieving the public(floating) address of a molecule instance returns a NoneType value, which in turn evaluates to False when compared to "" , which cause the private address of the instance to never get picked up as fallback. This commit changes the condition to not address | bool which in both case will evaluate to True if the retrieval of the public ip failed.
This will fix #325