feat(podman): Add driver schema#335
feat(podman): Add driver schema#335ziegenberg wants to merge 2 commits intoansible-community:mainfrom
Conversation
ziegenberg
changed the title
ziegenberg
force-pushed
the
add-podman-driver-schema
branch
from
ae5f7cc to
84407bb
Compare
ziegenberg
force-pushed
the
add-podman-driver-schema
branch
from
84407bb to
57a7b4b
Compare
ziegenberg
force-pushed
the
add-podman-driver-schema
branch
from
57a7b4b to
36472f2
Compare
|
@ziegenberg thanks for working on this! But it seems like your fix got stuck due to "Label error". I'm not sure if I understand correctly how this works, but could it be that to make it work the commit message would need to start with "feat:" instead of "feat(podman):" ? (because "feat:" is one of the types accepted?) |
There was a problem hiding this comment.
Pull request overview
This PR adds JSON schema validation support for the Podman driver to eliminate the warning about missing driver schema.
Changes:
- Added a comprehensive JSON schema file defining the Podman driver and platform configuration structure
- Implemented the
schema_file()method in the Podman driver class to return the path to the schema file
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/molecule_plugins/podman/schema/driver.json | New JSON schema file defining validation rules for Podman driver configuration with detailed property definitions for platforms and driver settings |
| src/molecule_plugins/podman/driver.py | Added schema_file() method to return the path to the driver's JSON schema file |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| def schema_file(self): | ||
| """Return the path to the driver's JSON schema file.""" | ||
| p = Path(self._path, "schema", "driver.json") | ||
| if p.is_file(): | ||
| return str(p) | ||
| return None |
There was a problem hiding this comment.
The new schema_file() method lacks test coverage. Consider adding a test in test/podman/test_driver.py to verify that the method returns the correct schema file path and handles the case when the file doesn't exist.
|
Hi @eliasrudberg, The commit message reads 'podman: Add driver schema', which should be absolutely fine and the label |
|
@ziegenberg thanks for answering! As the problem seems to be that the check is not happy with what the bot is doing, would it be possible to either disable the bot, or disable the check (perhaps enable again after the merge is done)? If that's not possible, is there anything else that could be done to get this fix merged? What would it take? I would like to help, if possible. |
|
Hi @eliasrudberg, You're overestimating my abilities here. I have no say over the bot or anything else. I have the same powers as you: basically none. I can create a pull request, and that's it. |
|
The last commit from one of the maintainers (@ssbarnea) was from four months ago. We just have to wait for them to return. If it's urgent, you may want to ask them in the |
|
@ziegenberg okay, I understand. Thanks for explaining! |
ziegenberg
force-pushed
the
add-podman-driver-schema
branch
from
36472f2 to
38910ef
Compare
Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
ziegenberg
force-pushed
the
add-podman-driver-schema
branch
from
38910ef to
2b35828
Compare
|
@ssbarnea could this get merged soon? It would be really nice to get rid of those warnings about missing schema! |
Currently, when running molecule with the podman driver, we get the following message:
So, let's add a schema 🎉
Fixes #304