feat: support inventory as a single file or directory - #551
Merged
Merged
Conversation
We don't load the inventory data in ansible-rulebook its passed into the ansible-runner as is.
Alex-Izquierdo
approved these changes
Jul 19, 2023
Alex-Izquierdo
left a comment
Alex-Izquierdo
left a comment
Contributor
There was a problem hiding this comment.
Inventory is value that remains through the live cycle of the process. Have you considered to moving this kind of things to a shared place, like https://github.com/ansible/ansible-rulebook/blob/main/ansible_rulebook/conf.py#L18 ?
That would allow us to reduce the number of params passed through functions.
A couple of questions, but LGTM
benthomasson
approved these changes
Aug 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't load the inventory data in ansible-rulebook its passed into the ansible-runner as is.
Based on work done in PR #523
#344
https://issues.redhat.com/browse/AAP-7661