Add more collection-test-* jobs - #3
Merged
Merged
Conversation
Signed-off-by: NilashishC <nchakrab@redhat.com>
NilashishC
changed the title
Signed-off-by: NilashishC <nchakrab@redhat.com>
NilashishC
force-pushed
the
add_more_tests
branch
from
April 23, 2025 05:54
dfd30ba to
8f9200a
Compare
Signed-off-by: NilashishC <nchakrab@redhat.com>
NilashishC
added a commit
that referenced
this pull request
Jun 19, 2025
* Add collection-test-integration-check * Add collection-test-completeness --------- Signed-off-by: NilashishC <nchakrab@redhat.com>
sean-m-sullivan
added a commit
that referenced
this pull request
Jul 22, 2025
* Add GHA workflows (#1) * Add GHA workflows Signed-off-by: NilashishC <nchakrab@redhat.com> --------- Signed-off-by: NilashishC <nchakrab@redhat.com> * Add integration test job (#2) Signed-off-by: NilashishC <nchakrab@redhat.com> * Add more collection-test-* jobs (#3) * Add collection-test-integration-check * Add collection-test-completeness --------- Signed-off-by: NilashishC <nchakrab@redhat.com> * Pull ansible/aap-gateway (#5) Signed-off-by: NilashishC <nchakrab@redhat.com> * Add build-import and DVCS check workflows (#8) * Add build-import and DVCS check workflows * remove redundant dependencies * Change to pull_request_target --------- Signed-off-by: NilashishC <nchakrab@redhat.com> * explicity use PR head when checking out (#10) * explicity use PR head when checking out --------- Signed-off-by: NilashishC <nchakrab@redhat.com> * Update collection.yml * updates (#11) Signed-off-by: NilashishC <nchakrab@redhat.com> * Revert collection.yml workflow to use on: pull_request (#13) Signed-off-by: NilashishC <nchakrab@redhat.com> * Update collection.yml * Assorted updates to workflows and issues templates (#16) * [AAP-43077] Assorted updates to workflows and issues templates --------- Signed-off-by: NilashishC <nchakrab@redhat.com> * AAP-43136 changes to token module (#7) * AAP-43113 adding changes to fix documentation for token module (#15) * fix branch name Signed-off-by: NilashishC <nchakrab@redhat.com> * AAP-32818: Adds an authentication related section in README * Adds a new section in README that describes how to use authentication variables in playbooks for connecting to AAP. * AAP-43078: addition of object_ids param to enable processing of a list of object_ids/names * Update ansible.platform settings module documentation examples (#32) Resolve ansible-lint errors Resolve few naming errors Replace <true_or_false> with true/false for better readability * [AAP-32819] Adds missing examples in authenticator and authenticator_map modules (#25) Co-authored-by: Shashank Venkat <shvenkat> * updating aap_module.py to match the other collections using startswith vs re.match * [AAP-43077] Fix intermittent SSLError when running test_completeness (#35) * [AAP-43077] Fix intermittent SSLError when running test_completeness --------- Signed-off-by: NilashishC <nchakrab@redhat.com> * [AAP-43077] Allow PRs originating from forks to run integration tests (#36) Signed-off-by: NilashishC <nchakrab@redhat.com> * Update main.yml * Update role_user_assignment.py * trying to fix CI * Update test_completeness.py * Update test_completeness.py * Update test_completeness.py --------- Signed-off-by: NilashishC <nchakrab@redhat.com> Co-authored-by: Nilashish Chakraborty <nchakrab@redhat.com> Co-authored-by: Kaushiki Singh <kausingh@redhat.com> Co-authored-by: Siddarth Sharma <149260801+PyContriver@users.noreply.github.com> Co-authored-by: tanwigeetika1618 <84617407+tanwigeetika1618@users.noreply.github.com> Co-authored-by: Shashank Venkat <shvenkat@redhat.com> Co-authored-by: Sean Sullivan <ssulliva@redhat.com>
26 tasks
jessicamack
added a commit
to jessicamack/ansible.platform
that referenced
this pull request
Aug 27, 2026
…check_mode, wait-timeout id loss - ansible#7: DirectHTTPClient._find_resource no longer requires a list op before attempting GET-by-id, matching PlatformService. Add optional list op to the ad_hoc_command mixin. - ansible#10: inventory/credential/execution_environment name lookups now hit /api/controller/v2/... instead of Gateway; DirectHTTPClient.lookup_resource_id honors full /api/-prefixed paths instead of always Gateway-prefixing. - ansible#9: check_mode short-circuits before manager.execute() instead of launching a real ad hoc command. - ansible#2: introduce WaitTimeoutError(ValueError) carrying the last poll result so a wait-timeout no longer drops the launched command's id/status. - ansible#8: mock server keeps ad hoc commands pending for 2 polls before resolving (with __fail__/__hang__ markers) instead of resolving instantly on create, so wait/poll logic is actually exercised in CI. - ansible#5: add unit tests for poll-to-completion, timeout, default-timeout, wait-flag popping, check_mode, and DirectHTTPClient-without-list-op. - ansible#3: document the 3600s default wait-timeout ceiling in DOCUMENTATION. - ansible#12: from_api now round-trips extra_vars (dict or JSON string) instead of always returning None. - Document terminal statuses in RETURN per the review's fallback guidance. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
jessicamack
added a commit
to jessicamack/ansible.platform
that referenced
this pull request
Sep 3, 2026
…check_mode, wait-timeout id loss - ansible#7: DirectHTTPClient._find_resource no longer requires a list op before attempting GET-by-id, matching PlatformService. Add optional list op to the ad_hoc_command mixin. - ansible#10: inventory/credential/execution_environment name lookups now hit /api/controller/v2/... instead of Gateway; DirectHTTPClient.lookup_resource_id honors full /api/-prefixed paths instead of always Gateway-prefixing. - ansible#9: check_mode short-circuits before manager.execute() instead of launching a real ad hoc command. - ansible#2: introduce WaitTimeoutError(ValueError) carrying the last poll result so a wait-timeout no longer drops the launched command's id/status. - ansible#8: mock server keeps ad hoc commands pending for 2 polls before resolving (with __fail__/__hang__ markers) instead of resolving instantly on create, so wait/poll logic is actually exercised in CI. - ansible#5: add unit tests for poll-to-completion, timeout, default-timeout, wait-flag popping, check_mode, and DirectHTTPClient-without-list-op. - ansible#3: document the 3600s default wait-timeout ceiling in DOCUMENTATION. - ansible#12: from_api now round-trips extra_vars (dict or JSON string) instead of always returning None. - Document terminal statuses in RETURN per the review's fallback guidance. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
jessicamack
added a commit
to jessicamack/ansible.platform
that referenced
this pull request
Sep 3, 2026
…check_mode, wait-timeout id loss - ansible#7: DirectHTTPClient._find_resource no longer requires a list op before attempting GET-by-id, matching PlatformService. Add optional list op to the ad_hoc_command mixin. - ansible#10: inventory/credential/execution_environment name lookups now hit /api/controller/v2/... instead of Gateway; DirectHTTPClient.lookup_resource_id honors full /api/-prefixed paths instead of always Gateway-prefixing. - ansible#9: check_mode short-circuits before manager.execute() instead of launching a real ad hoc command. - ansible#2: introduce WaitTimeoutError(ValueError) carrying the last poll result so a wait-timeout no longer drops the launched command's id/status. - ansible#8: mock server keeps ad hoc commands pending for 2 polls before resolving (with __fail__/__hang__ markers) instead of resolving instantly on create, so wait/poll logic is actually exercised in CI. - ansible#5: add unit tests for poll-to-completion, timeout, default-timeout, wait-flag popping, check_mode, and DirectHTTPClient-without-list-op. - ansible#3: document the 3600s default wait-timeout ceiling in DOCUMENTATION. - ansible#12: from_api now round-trips extra_vars (dict or JSON string) instead of always returning None. - Document terminal statuses in RETURN per the review's fallback guidance. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
jessicamack
added a commit
to jessicamack/ansible.platform
that referenced
this pull request
Sep 15, 2026
…check_mode, wait-timeout id loss - ansible#7: DirectHTTPClient._find_resource no longer requires a list op before attempting GET-by-id, matching PlatformService. Add optional list op to the ad_hoc_command mixin. - ansible#10: inventory/credential/execution_environment name lookups now hit /api/controller/v2/... instead of Gateway; DirectHTTPClient.lookup_resource_id honors full /api/-prefixed paths instead of always Gateway-prefixing. - ansible#9: check_mode short-circuits before manager.execute() instead of launching a real ad hoc command. - ansible#2: introduce WaitTimeoutError(ValueError) carrying the last poll result so a wait-timeout no longer drops the launched command's id/status. - ansible#8: mock server keeps ad hoc commands pending for 2 polls before resolving (with __fail__/__hang__ markers) instead of resolving instantly on create, so wait/poll logic is actually exercised in CI. - ansible#5: add unit tests for poll-to-completion, timeout, default-timeout, wait-flag popping, check_mode, and DirectHTTPClient-without-list-op. - ansible#3: document the 3600s default wait-timeout ceiling in DOCUMENTATION. - ansible#12: from_api now round-trips extra_vars (dict or JSON string) instead of always returning None. - Document terminal statuses in RETURN per the review's fallback guidance. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.