Move to Runtime Platform Flags - #16148
Merged
Merged
Conversation
github-actions
Bot
added
component:api
dependencies
fao89
marked this pull request as draft
October 27, 2025 15:07
fao89
force-pushed
the
zk-platform-flags
branch
from
October 27, 2025 15:29
5f6ba99 to
58f9133
Compare
11 tasks
This comment was marked as resolved.
This comment was marked as resolved.
fao89
force-pushed
the
zk-platform-flags
branch
from
October 28, 2025 17:30
58f9133 to
a188433
Compare
fao89
marked this pull request as ready for review
October 30, 2025 19:06
AlanCoding
reviewed
Nov 13, 2025
| git+https://github.com/ansible/ansible-runner.git@devel#egg=ansible-runner | ||
| awx-plugins-core @ git+https://github.com/ansible/awx-plugins.git@devel#egg=awx-plugins-core[credentials-github-app] | ||
| django-ansible-base @ git+https://github.com/ansible/django-ansible-base@devel#egg=django-ansible-base[rest-filters,jwt_consumer,resource-registry,rbac,feature-flags] | ||
| django-ansible-base @ git+https://github.com/fao89/django-ansible-base@phase2/feature-flags/poc#egg=django-ansible-base[rest-filters,jwt_consumer,resource-registry,rbac,feature-flags] |
AlanCoding
approved these changes
Nov 13, 2025
fao89
force-pushed
the
zk-platform-flags
branch
from
November 24, 2025 20:38
a188433 to
e39480a
Compare
github-actions
Bot
removed
the
dependencies
fao89
force-pushed
the
zk-platform-flags
branch
2 times, most recently
from
November 24, 2025 21:18
d7c4920 to
10f9065
Compare
github-actions
Bot
added
the
dependencies
fao89
force-pushed
the
zk-platform-flags
branch
2 times, most recently
from
November 24, 2025 21:52
8d3853d to
d5083f3
Compare
Signed-off-by: Fabricio Aguiar <fabricio.aguiar@gmail.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
fao89
force-pushed
the
zk-platform-flags
branch
from
November 25, 2025 11:47
d5083f3 to
571cb37
Compare
fao89
force-pushed
the
zk-platform-flags
branch
from
November 25, 2025 13:22
63fce97 to
53905bb
Compare
|
fao89
commented
Nov 25, 2025
Comment on lines
+155
to
+156
| # Filter out files that are excluded by .coveragerc to avoid coverage conflicts | ||
| # This prevents SonarCloud from analyzing files that have no coverage data |
Member
Author
There was a problem hiding this comment.
@AlanCoding could you help me understand why sonar fails?
test is there but it seems coveragerc is making sonar blind
thedoubl3j
approved these changes
Nov 25, 2025
thedoubl3j
left a comment
thedoubl3j
left a comment
Member
There was a problem hiding this comment.
thank you for the workflow updates @fao89. the new workflow stuff will not take effect until the PR merges so the gate will never actually be met in this PR. I think merging as things stand is fine by me.
Jaapis
pushed a commit
to Jaapis/awx
that referenced
this pull request
Feb 4, 2026
…7221) * Move to Runtime Platform Flags (ansible#16148) * move to platform flags cherrypick from: ansible#16148 Signed-off-by: Fabricio Aguiar <fabricio.aguiar@gmail.com> Signed-off-by: Fabricio Aguiar <fabricio.aguiar@gmail.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED * Update tests to use flags.state API for runtime platform flags Tests updated: - test_indirect_host_counting: use enable_flag()/disable_flag() - test_cleanup_old_audit_records: use enable_flag()/disable_flag() - TestGenericRun::test_awx_task_env: use @pytest.mark.django_db instead of mock For test classes with many tests (TestJobCredentials, TestInventoryUpdateCredentials), keep mock_flag_enabled fixtures to avoid adding @pytest.mark.django_db to 60+ tests. --------- Co-authored-by: Hao Liu <44379968+TheRealHaoLiu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move to Runtime Platform Flags
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
This PR moves the source of truth for feature flags from components to the platform, inheriting and leveraging platform flags.
This PR requires - ansible/django-ansible-base#875 to be merged in first.