Skip to content

Remove unused setting - #16624

Open
AlanCoding wants to merge 1 commit into
ansible:develfrom
AlanCoding:not_waiting_anymore
Open

AlanCoding wants to merge 1 commit into
ansible:develfrom
AlanCoding:not_waiting_anymore

Conversation

@AlanCoding

@AlanCoding AlanCoding commented Aug 28, 2026

Copy link
Copy Markdown
Member
SUMMARY

the waiting job reaper was removed but this was still lying around

ISSUE TYPE
  • Bug, Docs Fix or other nominal change
COMPONENT NAME
  • API

Summary by CodeRabbit

  • Chores
    • Removed the obsolete job waiting grace-period setting from the application’s default configuration.
    • Removed the associated configuration documentation.

@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 892eec17-ad87-4f61-b101-bd42b6418977

📥 Commits

Reviewing files that changed from the base of the PR and between 938f7ab and 260ad67.

📒 Files selected for processing (1)
  • awx/settings/defaults.py
💤 Files with no reviewable changes (1)
  • awx/settings/defaults.py

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The default settings remove JOB_WAITING_GRACE_PERIOD and its documentation. Jobs no longer receive this configurable 60-second grace period beyond the task manager timeout.

Changes

Job waiting settings

Layer / File(s) Summary
Remove grace period setting
awx/settings/defaults.py
Removes the JOB_WAITING_GRACE_PERIOD = 60 default and its documentation.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 260ad

This localized cleanup removes an unused setting without introducing an actionable merge-blocking risk; it is merge-ready after normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: removal of an unused setting. It is concise and specific enough for the change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant