ci: extend Java testing with 17 & 21 with py3.12 - #79
Merged
Merged
Conversation
📝 WalkthroughWalkthroughThe CI workflow matrix gains a ChangesCI Matrix Java Version Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/python_package.yml:
- Around line 21-22: The checkout action in the workflow is missing the
persist-credentials parameter, which leaves the authentication token in the git
config and creates a security vulnerability. Add the persist-credentials: false
parameter to the actions/checkout@v6 step to ensure the authentication token is
not persisted in the git configuration after the checkout completes.
- Around line 21-24: Replace all mutable action version tags with full commit
SHAs to improve CI supply-chain security. Update the actions/checkout reference
from `@v6` to its corresponding full commit SHA, the actions/setup-java reference
from `@v5` to its corresponding full commit SHA, and also update the other
instances using `@v6` on line 29 and `@v7` on line 50 to their respective full
commit SHAs. Use the format uses:
action-name@SHA256:XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX for each action
reference throughout the workflow file.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Enterprise
Run ID: 19b012f1-2aa1-4d54-a6ec-4deb61d80b01
📒 Files selected for processing (1)
.github/workflows/python_package.yml
ptoscano
changed the title
Make it possible to test multiple versions of Java rather than only 18. To avoid testing every Java version with every Python version, only Python 3.12 is used for testing different Java versions, keeping only 18 for other Python versions. Also add: - Java 17: the LTS currently in use by ansible-rulebook - Java 21: supported by drools-ansible-integration
jcraiglo1
approved these changes
Jun 22, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make it possible to test multiple versions of Java rather than only 18. To avoid testing every Java version with every Python version, only Python 3.12 is used for testing different Java versions, keeping only 18 for other Python versions.
Also add:
Summary by CodeRabbit
Summary by CodeRabbit