fix: [AAP-91811] replace is_defined guards with default('') for VSO secret support

[sunalawa]

event_stream.database_secret and event_persistence.database_secret used
'is defined' guards which break when an empty-string default is added —
the same pattern fixed in galaxy-operator PR #283. Replaced with
'| default('') | length' so both undefined and '' are treated as unset,
allowing VSO-pre-created secrets to be correctly preserved on reconcile.

Ref: AAP-91811, ANSTRAT-2212
Signed-off-by: Suyash Nalawade sunalawa@redhat.com

Summary by CodeRabbit

• Refactor
  • Simplified PostgreSQL configuration checks while preserving existing behavior.
  • Secret validation continues to run only when non-empty values are provided.
  • Tasks remain skipped when relevant secrets are missing or empty.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: e0c2df93-ed39-4a5d-9931-aa0f38f91083

📥 Commits

Reviewing files that changed from the base of the PR and between a4646fc and 24f6a88.

📒 Files selected for processing (3)

• roles/postgres/tasks/main.yml
• roles/postgres/tasks/set_event_persistence_secret.yml
• roles/postgres/tasks/set_event_stream_secret.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

The PostgreSQL role replaces explicit secret-definedness and length checks with default('') and truthiness expressions. The updated conditions preserve existing behavior for undefined, empty, and non-empty secrets.

Changes

PostgreSQL secret guard simplification

Layer / File(s)	Summary
Simplify PostgreSQL secret conditions roles/postgres/tasks/main.yml, roles/postgres/tasks/set_event_stream_secret.yml, roles/postgres/tasks/set_event_persistence_secret.yml	The event stream and event persistence task guards now use defaulted secret lengths or truthiness checks. Undefined and empty secrets produce the same task decisions as before.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 24f6a

No concrete merge-blocking risk is established by the available evidence.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the main change: replacing is_defined guards with default('') for VSO secret support.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

Git: CodeRabbit could not clone the repository, so clone-backed analysis was skipped and this review may be incomplete. Verify repository clone access, such as SSH credentials, before requesting another full review. If clone access is intentionally unavailable, use path_filters to narrow the review scope.

---

_{Comment @coderabbitai help to get the list of available commands.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud