Skip to content

move to platform flags - #1440

Merged
zkayyali812 merged 1 commit into
ansible:mainfrom
fao89:rff
Jan 7, 2026
Merged

zkayyali812 merged 1 commit into
ansible:mainfrom
fao89:rff

Conversation

@fao89

@fao89 fao89 commented Dec 18, 2025

Copy link
Copy Markdown
Member

Signed-off-by: Fabricio Aguiar fabricio.aguiar@gmail.com

(cherry picked from commit 84e065aab03d7bb7c3638eb6a40f165ada7b78fe)

(#1407 should be backported to 2.6)

@fao89
fao89 requested a review from a team as a code owner December 18, 2025 16:12
zkayyali812
zkayyali812 previously approved these changes Dec 18, 2025
@zkayyali812
zkayyali812 dismissed their stale review December 18, 2025 16:16

Failing CI

@zkayyali812

zkayyali812 commented Dec 18, 2025

Copy link
Copy Markdown
Collaborator

@fao89 PR looks mostly good, but we appear to be failing lint/CI.
I think we don't need all the changes in the poetry.lock that are brought in, I wonder if those are causing the failures here

@codecov-commenter

codecov-commenter commented Dec 18, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.20%. Comparing base (fe3646f) to head (c36a14a).

@@           Coverage Diff           @@
##             main    #1440   +/-   ##
=======================================
  Coverage   91.20%   91.20%           
=======================================
  Files         232      232           
  Lines        9939     9942    +3     
=======================================
+ Hits         9065     9068    +3     
  Misses        874      874           
Flag Coverage Δ
unit-int-tests-3.11 91.20% <100.00%> (+<0.01%) ⬆️
unit-int-tests-3.12 91.20% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/aap_eda/settings/core.py 100.00% <ø> (ø)
tests/conftest.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fao89
fao89 force-pushed the rff branch 2 times, most recently from 4a49334 to 531673d Compare December 18, 2025 17:54
Signed-off-by: Fabricio Aguiar <fabricio.aguiar@gmail.com>

(cherry picked from commit 84e065aab03d7bb7c3638eb6a40f165ada7b78fe)
Signed-off-by: Fabricio Aguiar <fabricio.aguiar@gmail.com>

Signed-off-by: Fabricio Aguiar <fabricio.aguiar@gmail.com>

Signed-off-by: Fabricio Aguiar <fabricio.aguiar@gmail.com>

Signed-off-by: Fabricio Aguiar <fabricio.aguiar@gmail.com>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@sonarqubecloud

sonarqubecloud Bot commented Jan 7, 2026

Copy link
Copy Markdown

@zkayyali812
zkayyali812 merged commit dc6b563 into ansible:main Jan 7, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants