[draft] make route annotations for cascading_timeout values be respected - #245
Open
rebeccahhh wants to merge 1 commit into
Open
rebeccahhh wants to merge 1 commit into
rebeccahhh wants to merge 1 commit into
Conversation
…t change rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
rebeccahhh
changed the title
Member
Author
|
sorry about the initially misleading title, was too in the weeds to see the sunshine. |
kdelee
reviewed
Mar 20, 2026
| # set these defaults the same way as Hub. | ||
| - name: set gunicorn_timeout based on annotation | ||
| set_fact: | ||
| gunicorn_timeout: "{{ (this_annotations['aap.ansible.io/gunicorn_timeout'][:-1]) | int }}" |
Member
There was a problem hiding this comment.
??? I thought we would just set this based on client_request_timeout and client_request_timeout comes from aap.ansible.io/client-request-timeout and do max(gunicorn_timeout, clien_request_timeout / 2) or whatever math we are currently trying to do in the default vars
Member
Author
There was a problem hiding this comment.
oh we absolutely can, but theoretically they could modify the timeout in the route so this would account for that. I don't think this is the "right" way per se, but was an option.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
SUMMARY
because defaults are set for galaxy (see config/crd/bases/galaxy_v1beta1_galaxy_crd.yaml), if the values are set in the route annotation they are not respected, this is one option to theoretically rectify that.
note: this is a DRAFT y'all :) there are a couple ways we could solve this but this seems the best.
ADDITIONAL INFORMATION
https://github.com/ansible/galaxy-operator/blob/main/config/crd/bases/galaxy_v1beta1_galaxy_crd.yaml
#207