Add configurable S3 checksum env vars for botocore >= 1.36.0 - #262
Draft
rooftopcellist wants to merge 1 commit into
Draft
rooftopcellist wants to merge 1 commit into
rooftopcellist wants to merge 1 commit into
Conversation
botocore 1.36.0 introduced automatic CRC32 checksums on S3 write operations via the x-amz-sdk-checksum-algorithm header. Non-AWS S3-compatible backends (GCS, MinIO, Ceph, etc.) do not support this header, causing SignatureDoesNotMatch errors. This adds two optional keys to the S3 storage secret: - s3-request-checksum-calculation - s3-response-checksum-validation Both default to "when_required" (pre-1.36.0 behavior), which is safe for all S3 backends including AWS. Users who need to enforce checksums on AWS S3 can set these to "when_supported". The values are set as environment variables on the galaxy-api, galaxy-content, and galaxy-worker deployments when S3 storage is configured. Ref: AAP-75239 Signed-off-by: Christian M. Adams <chadams@redhat.com>
rooftopcellist
marked this pull request as draft
May 15, 2026 14:46
Member
Author
|
Needs more discussion on if this is the right approach or not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
s3-request-checksum-calculationands3-response-checksum-validationwhen_required(pre-botocore 1.36.0 behavior), which is safe for all S3 backendswhen_supportedAWS_REQUEST_CHECKSUM_CALCULATION,AWS_RESPONSE_CHECKSUM_VALIDATION) on galaxy-api, galaxy-content, and galaxy-worker deploymentsContext
botocore >= 1.36.0 (January 2025) automatically computes CRC32 checksums on S3 write operations. Non-AWS S3-compatible backends (GCS, MinIO, Ceph, Backblaze B2, etc.) do not support the
x-amz-sdk-checksum-algorithmheader, causingSignatureDoesNotMatcherrors.Defaulting to
when_requiredrestores pre-1.36.0 behavior while keeping the setting configurable for users who want checksum enforcement on native AWS S3.Ref