Remove references to operator_service_account_name - #285
Open
skashid1882 wants to merge 1 commit into
Open
skashid1882 wants to merge 1 commit into
skashid1882 wants to merge 1 commit into
Conversation
The operator_service_account_name variable is no longer used by any operator role or template. This commit removes: - The variable definition from roles/common/defaults/main.yml - The OPERATOR_SA_NAME env var from config/testing/manager_image.yaml - The molecule test variable override from molecule/kind/molecule.yml - The RBAC Role/RoleBinding test tasks from molecule/default/tasks/pulp_test.yml Fixes ansible#50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the vestigial
operator_service_account_namevariable which is no longer used by any operator role or template.Fixes #50
Changes
roles/common/defaults/main.yml— Removed the variable definitionconfig/testing/manager_image.yaml— Removed theOPERATOR_SA_NAMEenv varmolecule/kind/molecule.yml— Removed the variable override in molecule group varsmolecule/default/tasks/pulp_test.yml— Removed the two RBAC tasks (Role and RoleBinding) that existed solely to grant permissions on the operator service accountNotes
The hardcoded service account name
galaxy-operator-sainconfig/rbac/role.yamland the ClusterServiceVersion manifest are NOT touched by this PR — those are direct references used by the operator's RBAC configuration and are still needed.