fix: handle suffixed gateway_sessionid in session expiry tracking - #132
Merged
Merged
Conversation
Commit 6d6def8 added startswith-based matching for the gateway_sessionid cookie in gw_auth_client.get_cookies_from_response, but missed the same hardcoded exact match in GalaxyClient.check_or_refresh_gateway_session. This causes session_expires to never be set on suffixed deployments (e.g. gateway_sessionid44927), triggering a re-login on every HTTP call and overwriting any intentionally corrupted test headers. Fixes: AAP-66185 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Ingrid Sena <10999758+fullsushidev@users.noreply.github.com>
dragid10
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Support custom gateway_sessionid (#131)) fixedgw_auth_client.get_cookies_from_responseto usestartswith("gateway_sessionid")for suffixed cookie names in 2.7+GalaxyClient.check_or_refresh_gateway_sessionstill uses an exact match (cookie.name != "gateway_sessionid"), sosession_expiresis never set on suffixed deployments_http()call to re-authenticate, overwriting any intentionally corrupted headers (breaking Gateway auth tests)startswithto match the same pattern asparse_custom_gateway_sessionidTest plan
test_gateway_auth_admin_gateway_sessionid,test_gateway_token_auth,test_gateway_create_ns_csrftoken) against a 2.7 deployment with suffixed cookieFixes: AAP-66185
🤖 Generated with Claude Code