Skip to content

fix: ignore workflow whitespace in validation - #40

Merged
cshiels-ie merged 3 commits into
ansible:develfrom
cshiels-ie:fix/validate-action-pin-whitespace
Sep 10, 2026
Merged

cshiels-ie merged 3 commits into
ansible:develfrom
cshiels-ie:fix/validate-action-pin-whitespace

Conversation

@cshiels-ie

Copy link
Copy Markdown
Contributor

Summary

  • Extend action-pin-only protected workflow validation to ignore harmless EOF/trailing whitespace differences.
  • Add regression coverage for a missing final newline alongside Dependabot action SHA changes.

This fixes the remaining framework validation failure on metrics-service PR #419, whose recorded framework snapshot differs from the generated workflow only by action SHAs and the final newline.

Testing

  • uv run ruff check src/platform_service_framework/cli.py
  • git diff --check
  • Clean-checkout regression test included for CI.

AI Assistance

This change was developed with assistance from OpenCode (openai/gpt-5.6-luna).
All generated code was reviewed, tested, and validated before merging.

Allow downstream Dependabot updates to framework-managed GitHub Action SHAs while continuing to reject substantive protected workflow changes.

Assisted-by: OpenCode <openai/gpt-5.6-luna>
Treat EOF newline differences as harmless alongside action pin-only workflow changes.

Assisted-by: OpenCode <openai/gpt-5.6-luna>
@cshiels-ie
cshiels-ie marked this pull request as ready for review September 10, 2026 20:43
@cshiels-ie
cshiels-ie merged commit 8a11c0b into ansible:devel Sep 10, 2026
7 checks passed
@cshiels-ie
cshiels-ie deleted the fix/validate-action-pin-whitespace branch September 10, 2026 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant