CHORE: Delete deprecation#7674
Draft
Samuelopez-ansys wants to merge 70 commits into
Draft
Conversation
Collaborator
SMoraisAnsys
left a comment
SMoraisAnsys
left a comment
There was a problem hiding this comment.
Here are some minor comments. Since some questions might require followup oin this PR, I'm not approving but it could be fine as it is :)
| @@ -2584,9 +2584,6 @@ def autosave_enable(self) -> bool: | |||
| def release_desktop(self, close_projects: bool = True, close_desktop: bool = True) -> bool: | |||
Collaborator
There was a problem hiding this comment.
Shouldn't we be removing the method and not the "deprecated:: ..." in the docstring ?
Can be performed in another PR were all deprecated mthods (not arguments) are removed.
Member
Author
There was a problem hiding this comment.
@SMoraisAnsys We decided that this method should not be deprecated, historically, many users have it, and it is useful to have it at design level.
…age_frequency_dependent_excitation_to_ports method
…ng in circuit methods
…_schematic_from_pins method
…ge and wave port methods
…ge and wave port methods
…and excitations in twinbuilder
…and excitations in twinbuilder
…matic and test cases
…lures and pin location changes
…ment and boundary creation failures
…ps in mechanical analysis
… in analysis, circuit, and other modules
…ield_exporter modules
…oordinate system changes
…to chore/delete_deprecation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request focuses on removing deprecated arguments and related deprecation mechanisms from several core modules, as well as making minor improvements to type hints and attribute usage. The changes simplify the codebase by eliminating obsolete code paths and cleanup of deprecated decorators, especially around analysis/export methods and schematic creation functions.
Deprecation cleanup and removal of deprecated arguments:
Removed the
deprecate_argumentdecorator and all related usages from functions inanalysis.py,circuit.py, anddesktop.py, eliminating support and warnings for deprecated arguments such asanalyzeandclose_on_exit.Removed the
deprecate_enumdecorator fromconstants.py, cleaning up deprecated enumeration handling.Type hint and signature improvements:
circuit.pyfor better clarity, including addingoptionalto parameters and refining type hints for arguments such asibis_rx_file,tx_buffer_name, and others.Attribute usage correction:
is3dwithis_3dinconfigurations.pyto match the correct attribute name.Issue linked
No issue linked
Checklist