Skip to content

Test the FieldHeader getter operator#2348

Draft
rafacanton wants to merge 16 commits into
mainfrom
rcanton/test_get_header
Draft

Test the FieldHeader getter operator#2348
rafacanton wants to merge 16 commits into
mainfrom
rcanton/test_get_header

Conversation

@rafacanton
Copy link
Copy Markdown
Collaborator

@rafacanton rafacanton commented Jun 6, 2025

A new operator has been added to be able to get the Header of a Field as a DataTree. This PR exposes and tests its getter

@rafacanton rafacanton self-assigned this Jun 6, 2025
@rafacanton rafacanton added tests Related to tests enhancement New feature or request labels Jun 6, 2025
@rafacanton
Copy link
Copy Markdown
Collaborator Author

This now fails as the server is not up-to-date. It passes with the right server: #2344

@rafacanton rafacanton requested a review from PProfizi June 6, 2025 14:40
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 6, 2025

The documentation for this pull request will be available at https://dpf.docs.pyansys.com/pull/2348. Please allow some time for the documentation to be deployed.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.11%. Comparing base (1095ea2) to head (e6a9aa7).
⚠️ Report is 419 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2348      +/-   ##
==========================================
+ Coverage   84.10%   84.11%   +0.01%     
==========================================
  Files          91       91              
  Lines       10529    10538       +9     
==========================================
+ Hits         8855     8864       +9     
  Misses       1674     1674              

Comment thread src/ansys/dpf/core/field.py Outdated
@rafacanton rafacanton requested a review from Sangsimon June 11, 2025 14:08
@rafacanton rafacanton marked this pull request as draft June 11, 2025 14:28
@rafacanton
Copy link
Copy Markdown
Collaborator Author

@Sangsimon Putting this work on hold so it can be more generic. I think this should fall on the Header exposure you will be working on. TODOs:

  • Expose a similar operator for StringFields (I don't know why I didn't do it, all pieces are there)
  • Expose the header getter here in the FieldBase class so all it children redirect the call to the appropriate op

@Sangsimon
Copy link
Copy Markdown

@Sangsimon Putting this work on hold so it can be more generic. I think this should fall on the Header exposure you will be working on. TODOs:

  • Expose a similar operator for StringFields (I don't know why I didn't do it, all pieces are there)
  • Expose the header getter here in the FieldBase class so all it children redirect the call to the appropriate op

We need to discuss this further so that I have more clarity on what we are trying to achieve with this generality.

@moe-ad moe-ad changed the base branch from master to main July 28, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request tests Related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants