fix: fix Field.data for LegacyGrpcServer#2668
Merged
Merged
Conversation
3 tasks
Contributor
|
Some tests with 'continue-on-error: true' have failed:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2668 +/- ##
==========================================
+ Coverage 84.26% 84.36% +0.10%
==========================================
Files 92 92
Lines 10858 10858
==========================================
+ Hits 9149 9160 +11
+ Misses 1709 1698 -11 |
rafacanton
approved these changes
Oct 10, 2025
Contributor
Author
|
Waiting for #2669 to have the configuration of the issue covered in the CI and verify that this fixes it. |
Contributor
Author
|
Fix confirmed. |
ansys-akarcher
pushed a commit
that referenced
this pull request
Dec 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A script using only a
LegacyGrpcServerwould raise anAttributeErrorinField._get_datawhen trying to create aDPFVectorDouble.This error type was no longer caught in #2141