FIX: issue #2213 fixed

[svandenb-dev]

This PR is fixing Pin mapping for Spice pin mapping. Grpc had pin name and number swapped.

Issue is fixed

closes #2213

[codacy-production]

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric	Results
Complexity	0
Duplication	0

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.}

[codecov-commenter]

Codecov Report

❌ Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.68%. Comparing base (5cbae21) to head (c1eeb85).
⚠️ Report is 192 commits behind head on main.

❌ Your patch status has failed because the patch coverage (83.33%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2217      +/-   ##
==========================================
+ Coverage   70.20%   75.68%   +5.48%     
==========================================
  Files         261      266       +5     
  Lines       42416    45482    +3066     
==========================================
+ Hits        29779    34425    +4646     
+ Misses      12637    11057    -1580     

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[hui-zhou-a]

I am concerned about this
"Also adding relative path for Spice model when absolute path is not provided (e.g like with cfg file). Code will search models located in project path."

There is no concept of "project" in pyedb. The "project path" will be changed after save_as(), and this change is hidden from the user.

[SMoraisAnsys]

LGTM, I left a few comments.

Is there a reason to remove that many tests ?

[svandenb-dev]

I am concerned about this "Also adding relative path for Spice model when absolute path is not provided (e.g like with cfg file). Code will search models located in project path."

There is no concept of "project" in pyedb. The "project path" will be changed after save_as(), and this change is hidden from the user.

I understand I will force user to providing absolute path for files.

[svandenb-dev]

LGTM, I left a few comments.

Is there a reason to remove that many tests ?

No I revered tests

LGTM, I left a few comments.

Is there a reason to remove that many tests ?

No was by mistake test are back

[SMoraisAnsys]

I am concerned about this "Also adding relative path for Spice model when absolute path is not provided (e.g like with cfg file). Code will search models located in project path."
There is no concept of "project" in pyedb. The "project path" will be changed after save_as(), and this change is hidden from the user.

I understand I will force user to providing absolute path for files.

Did you do that in this PR or do you plan to perform that in another one ?