-
Notifications
You must be signed in to change notification settings - Fork 71
chore: Update new meshing workflow to enable switching. #5181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
658328d
chore: Update nre meshing workflow to enable switching.
prmukherj 134bd6e
chore: adding changelog file 5181.maintenance.md [dependabot-skip]
pyansys-ci-bot 272717d
Update docs.
prmukherj 86beb69
Skip creating rp vars test.
prmukherj ddbc552
Update tests.
prmukherj 6982675
Update docs.
prmukherj b10b448
Update doc structuring.
prmukherj 2aee2c7
Update doc structuring.
prmukherj 2360046
Update doc structuring.
prmukherj 5430893
Remove legacy section of docs.
prmukherj 68f0406
Remove legacy section of docs.
prmukherj 684b73d
Remove legacy section of docs.
prmukherj 3a9b752
Apply suggestion from @prmukherj
prmukherj 60437ea
Update vale.
prmukherj 5fc9026
Update vale.
prmukherj fceb449
Update vale.
prmukherj 0ff99da
Updates.
prmukherj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Update new meshing workflow to enable switching. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,7 +7,7 @@ Legacy interfaces | |
| :maxdepth: 1 | ||
| :hidden: | ||
|
|
||
| meshing_workflow | ||
| meshing_workflows | ||
| rpvars | ||
| scheme | ||
| tui | ||
This file was deleted.
Oops, something went wrong.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are the two separate legacy items here, meshing_workflow & meshing_workflows?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One is the classic meshing workflow with the task based approach. The other is object based one that we had achieved with the python wrapper. The later contains only some behavior changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, probably OK then
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the tree and docs they appear as "Legacy meshing interface" and "Classic meshing workflow".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. In the sequence v1 -> v2 -> v3, we're including v1 & v2 in legacy. We're including v2 because we think we're being fair to users when actually we might only be confusing them (and I'm sure that's an understatement). The fairest, kindest thing might be to erase v2 from history altogether, asserting that it was only ever an early alpha framework, leading to v3 - and that's a pretty honest assessment anyway.