Feature: Add File Browser Functionality to Everything Search - #56
Merged
Merged
Conversation
Adds fileBrowser functionality fileBrowser option added to Search Everything palette fileBrowser command accessible by / and /c Use existing path-tracking, minimal extra load
Remove visual bug switching between palette modes Change title to 'Browse folders' add nested path ui [e.g., "...parent/child"]
Hover tooltip adds little value to /path/ and poses chromium issues. Fix: remove tooltip
ant981228
added a commit
that referenced
this pull request
Sep 19, 2026
… document's folder, text searches the folder you're in Reworks PR #56's folder browser into the palette's prefix model. `/ ` and `/c ` end at whitespace like the letter prefixes (a bare `/` shows a hint instead of running the everything search over a slash); the query after the prefix searches the current folder at any depth, with each file carrying its sub-path, plus subfolders whose name matches. Enter/Tab step into a folder and Esc steps up, both clearing the query; only a change of prefix relocates, so wandering off after `/c ` and typing never snaps back. The listing derivation moves to src/editor/file-browse.ts, a pure, separator-agnostic helper shared by the index service and the palette test fake (which now implements browse/locateCurrentFile, fixing the typecheck). Folders exist only while an indexed file sits beneath them; relative directories reject any .. or absolute segment. Tests cover the helper, the service, and the palette flow; manual and changelogs updated. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015vDCxeP1FvdfeEWXSKqzao
ant981228
added a commit
that referenced
this pull request
Sep 19, 2026
…worked as a palette prefix) Folder browsing in the Search Everything palette: `/ ` starts at the file-search roots, `/c ` in the current document's folder, and text after the prefix searches the folder you are in. Contributor's branch plus the maintainer rework on top (pure shared listing helper, prefix-transition model, tests, docs). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015vDCxeP1FvdfeEWXSKqzao
Owner
|
Merged — thank you for this! Browsing by place rather than by name was a real gap, and the approach of deriving folders from the existing index (so nothing new touches the filesystem) was exactly right. Before merging I reworked it into the palette's prefix model so it behaves like the other prefixes. What changed, in case you're curious:
It's on main now and will ship with the next release. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Browse Folders, Too!
Everything Search is so much help, but sometimes our knowledge of a file is geographic instead of nominal. What do you do if you know where something is, but not what its called? Before, you'd have to open an explorer/finder, or use card mirror's existing open-file interface. Now, with fileBrowser, you can navigate to that folder from within card mirror!
What it adds
This PR adds a new functionality to the Search Everything palette designed to navigate to and through folders.
"browse" mode is accessible by the search-prefix
/Upon typing, users are sent to the 'roots' of the folders configured for File Search.
Users can also jump to the 'current' folder that houses the file currently open by adding a
cto the prefix, i.e.,:/cIf that file isn't within a configured root folder for File Search, the user will be told that jumping to that file's folder is impossible.Users can navigate the folder by clicking/tabbing, and can go "up" a folder by pressing esc.
Once at a folder, users can access / interface with the files in that folder as if the file was found through
fsearch. All functionality is preserved. Browse folder usesfsearch's existing index system to find file paths. Folders are only shown if they have files inside that are accessible byfsearch