fix: unable to update the port data when it is already in use#40
Open
ilyaliao wants to merge 2 commits intoantfu:mainfrom
Open
fix: unable to update the port data when it is already in use#40ilyaliao wants to merge 2 commits intoantfu:mainfrom
ilyaliao wants to merge 2 commits intoantfu:mainfrom
Conversation
Owner
|
Could we use https://www.npmjs.com/package/get-port-please ? It would align more with our ecosystem and has zero-deps. Thank you |
Author
|
I update it 😀 I noticed the portfinder will automatically select the host based on ipv4 or ipv6, but get-port-please seems not ...? If the host is not ::1, get-port-please can not correct work (always return 4000). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue where data was not correctly updated when port 4000 was in use.
I noticed that listening to http.createServer() does not adequately detect if a port is already in use.
As seen in the screenshot, port 4000 is in use, but both npx vite and the notification still show port 4000.
I resolved this by installing portfinder to check for port occupancy and obtain a new port if necessary.
When port 4000 is in use.
When port 4001 is in use.