ANT-500: fix agent comments not syncing to Jira#5
Merged
Conversation
TaskService.createAgentComment publishes comment:created with a map payload, while enqueueCommentOutbox only accepted handler.CommentResponse. Agent comments were therefore never mirrored to external trackers. Accept both payload shapes (matching notification/subscriber listeners) and add regression coverage for the map path and author-label resolution. Closes ANT-500
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TaskService.createAgentCommentpublishcomment:createdwith amap[string]anypayload.handler.CommentResponse, so those events were dropped before enqueueingpush_commentoutbox rows.Fix
enqueueCommentOutboxviaextractCommentFields(same dual-shape contract as notification/subscriber listeners).CommentResponseextraction and end-to-end outbox enqueue when issue-sync tables are present.Test plan
go test ./cmd/server -run TestExtractCommentFields(pass)issue_sync_sourceexists (skips cleanly on unmigrated DBs)**AgentName (via Multica):**prefixCloses ANT-500