view: add #[diagnostic::on_unimplemented] hint to HasMessageView#161
Merged
Conversation
When a bound on HasMessageView fails - typically in downstream generated code such as connect-rust service stubs, where the user cannot annotate the call site - the compiler error now explains the cause and the fix: regenerate the defining crate with buffa 0.7.0 or newer and views enabled (generate_views(true) in buffa-build/buffa-codegen, views=true for protoc-gen-buffa), or enable the crate's views feature when the generated impls are feature-gated. Mirrors the existing ViewEncode diagnostic in the same module.
|
All contributors have signed the CLA ✍️ ✅ |
rpb-ant
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
#[diagnostic::on_unimplemented]hint tobuffa::HasMessageView, mirroring the existingViewEncodediagnostic in the same module.HasMessageViewimpls are emitted by codegen next to each message's view types (since 0.7.0). Downstream consumers bound on it in generated code — most prominently connect-rust's service stubs, where the unsatisfied bound surfaces inside the consumer's generated file at a call site they cannot annotate. With this change the error explains the cause and the fix instead of only naming the missing trait bound:(Rendered output verified against a views-off generated type from
buffa-test.)Notes
#[diagnostic::on_unimplemented]stabilized in Rust 1.78; MSRV is 1.87, andViewEncodealready carries the same attribute form.