feat(view): reserve capacity for packed repeated fields (#171)#172
Closed
yanmo42 wants to merge 1 commit into
Closed
feat(view): reserve capacity for packed repeated fields (#171)#172yanmo42 wants to merge 1 commit into
yanmo42 wants to merge 1 commit into
Conversation
Optimize packed repeated scalar view decoding by reserving capacity based on the payload length. This reduces reallocations and provides a ~30% performance boost in microbenchmarks.
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Author
|
submitted prematurely, will re-evaluate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements capacity reservation for packed repeated scalar view fields as suggested in #171.
Performance
Using the reproduction provided in #171, this change reduces decoding time by approximately 30.4% (7.94s -> 5.53s) on my environment by eliminating redundant reallocations during view creation.
Implementation
RepeatedView::reserveto the public (but hidden) view API..reserve()calls before decoding packed fields.Validation
RepeatedView::reservepassed.test_view_packed_scalar_reserves_capacitypassed.buffaandbuffa-codegenunit tests passed.buffaandbuffa-codegen.