Repository navigation
Token Weather: read hasSurvey and bodyColumns from e.props - #17
Open
aquarius-wing wants to merge 1 commit into
Open
aquarius-wing wants to merge 1 commit into
aquarius-wing wants to merge 1 commit into
Conversation
The AbovePrompt hook read e.hasSurvey and e.bodyColumns, but ui.render carries the site's data in e.props. Both reads were always undefined, so the band never yielded to a survey and always laid itself out for 80 columns.
aquarius-wing
requested review from
ThariqS,
addy-ant,
cj-ant and
rlancemartin
as code owners
October 14, 2026 07:43
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Token Weather's
ui.renderhook forAbovePromptreadse.hasSurveyande.bodyColumns.ui.rendercarries a site's data ine.props(the render sites table in the mods reference listshasSurveyandbodyColumnsas props ofAbovePrompt), so both reads are alwaysundefined:hasSurvey: the band never yields while a survey holds it, so the forecast is drawn in the survey's place.bodyColumns: the width check always falls back to 80, so the chart and the trend are drawn even on a band narrower than 60 columns, whereband()means to leave them out.This change reads both from
e.props. Nothing else changes.Checked with
claude plugin validateand a throwawayclaude plugin testfile (not included, since #4 adds a test file of the same name) on Claude Code 2.1.295. After oneturn.completewith a reading, the band is mounted on the terminal surface:hasSurvey: truebodyColumns: 40bodyColumns: 120(control)Related: #7 makes the band compose with the mods beneath it and touches the same
return band(...)line, so whichever lands second needs a one-line merge. #12 also made this fix as part of a larger change and was closed.I've read CONTRIBUTING.md and understand outside pull requests may be closed without review. Feel free to take the fix in whatever form suits the private source repository.
Directory
claude-code/mods/token-weather/Pre-flight
Full checklist:
_template/PREFLIGHT.md_template/README.mdand the pre-flight scan passes (README unchanged; the scan is in the private repository, not run)🤖 Generated with Claude Code