Skip to content

client: error on truncated Connect streaming responses#146

Open
Yong-yuan-X wants to merge 1 commit into
anthropics:mainfrom
Yong-yuan-X:fix/issue-140-connect-stream-truncated-response
Open

client: error on truncated Connect streaming responses#146
Yong-yuan-X wants to merge 1 commit into
anthropics:mainfrom
Yong-yuan-X:fix/issue-140-connect-stream-truncated-response

Conversation

@Yong-yuan-X
Copy link
Copy Markdown
Contributor

Summary

  • return an error when a Connect streaming response body ends before an END_STREAM envelope is received
  • add a regression test for a response that yields a data envelope and then EOFs without END_STREAM
  • document the client-visible behavior change in the changelog

Closes #140.

Testing

  • cargo check -p connectrpc --all-features --all-targets
  • cargo clippy -p connectrpc --all-features --all-targets -- -D warnings
  • cargo test -p connectrpc connect_server_stream_truncated_after_data_errors
  • cargo check -p connectrpc --no-default-features
  • cargo test -p connectrpc --no-default-features
  • RUSTDOCFLAGS='-Dwarnings' cargo doc -p connectrpc --all-features --no-deps

@github-actions
Copy link
Copy Markdown

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

client: surface truncated Connect streaming responses as an error

1 participant