Skip to content

client: tighten gRPC and gRPC-Web unary response parsing#147

Open
jeet-dekivadia wants to merge 1 commit into
anthropics:mainfrom
jeet-dekivadia:codex/tighten-grpc-unary-response-parsing
Open

client: tighten gRPC and gRPC-Web unary response parsing#147
jeet-dekivadia wants to merge 1 commit into
anthropics:mainfrom
jeet-dekivadia:codex/tighten-grpc-unary-response-parsing

Conversation

@jeet-dekivadia
Copy link
Copy Markdown

@jeet-dekivadia jeet-dekivadia commented May 30, 2026

Summary

  • stop collecting gRPC-Web unary body frames once a complete trailers frame is buffered
  • reject a second unary response message before attempting decompression
  • add focused regressions for both parser paths

Why

Unary and client-streaming responses have a single-message shape. Failing fast avoids unnecessary decompression work and lets well-formed gRPC-Web responses finish without waiting for body EOF after trailers arrive.

Validation

  • git diff --check
  • cargo +nightly fmt --all -- --check
  • cargo check --workspace --all-features --all-targets
  • cargo test --workspace --all-features
  • cargo clippy --workspace --all-features --all-targets -- -D warnings

Fixes #138

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 30, 2026

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@jeet-dekivadia
Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

github-actions Bot added a commit that referenced this pull request May 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

client: tighten gRPC and gRPC-Web unary response parsing

1 participant