Add Moody's as a partner-built plugin#272
Conversation
prasanthlouis
force-pushed
the
feature/moodys-skills
branch
from
dc169cc to
7ab34b1
Compare
prasanthlouis
force-pushed
the
feature/moodys-skills
branch
from
7ab34b1 to
782f7f3
Compare
prasanthlouis
changed the title
cxyback
left a comment
cxyback
left a comment
There was a problem hiding this comment.
Thanks for putting this together — the skills themselves look high-quality and detailed (the earnings-brief flow and the template-driven build_pptx.py in particular). Structure matches the spglobal/ partner-plugin convention, no secrets in the diff, and the shared citations/template factoring is nice.
A few things to clean up before merge — mostly metadata/convention hygiene, with one real blocker on licensing (see inline). Happy to re-review once those are addressed.
|
|
||
| ## License | ||
|
|
||
| Proprietary — Moody's Corporation. See repository root for full license terms. |
There was a problem hiding this comment.
Blocker — license contradiction. This says "Proprietary — Moody's Corporation", but the plugin also ships an Apache 2.0 LICENSE file. Those can't both be true. Since this lands in our public-facing repo, we need to confirm with Moody's which one applies and remove the other before merge.
There was a problem hiding this comment.
Referenced Apache license: c7f0cae#diff-8b3e71dead6cab57c5fa7db762d3d62e22ce7a1475869f4ac18b8ae2e00abafdL67
| @@ -0,0 +1,8 @@ | |||
| { | |||
| "name": "moodys-skills", | |||
There was a problem hiding this comment.
Name mismatch. marketplace.json registers this plugin as "moodys", but here it's "moodys-skills". Pick one (suggest moodys to match the directory and the S&P pattern).
Also, this manifest is sparse vs. the spglobal convention — that one carries email, homepage, repository, license, and keywords. We should hold partners to the same metadata bar; at minimum add license (once the README/LICENSE conflict above is resolved), homepage, and a maintainer email.
There was a problem hiding this comment.
Updated this as moodys: c7f0cae#diff-818d5a5b99691dc7950440b94fc921f10090bdc8486731a662c94eb367ece7fdR2
Added more fields as well. Thank you!
| }, | ||
| { | ||
| "name": "moodys", | ||
| "displayName": "Moody's", |
There was a problem hiding this comment.
Description reads like a placeholder. Suggest matching the S&P entry's depth, e.g.:
"Moody's — Credit data and analytics skills including issuer briefs, sector briefs, peer/rating analysis, and earnings-call summaries."
There was a problem hiding this comment.
Updated the description with the suggestion:
c7f0cae#diff-5352ee4067f17e7948e1425843f0a454e045bc8edf338f0bcf75c6804ddabd9aR125
Also added more fields in the plugin.json
Thank you!
| "url": "https://api.moodys.com/genai-ready-data/Credit/mcp" | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Nit: two trailing whitespace-only lines and no newline at EOF. Also, the server is named moodys-m1-mcp here but the README table calls it Moodys MCP server — worth aligning.
There was a problem hiding this comment.
Updated the readme: c7f0cae#diff-8b3e71dead6cab57c5fa7db762d3d62e22ce7a1475869f4ac18b8ae2e00abafdL61
Removed whitespaces: c7f0cae#diff-0b17876b36c270997132815de10426dbd0be81130650fbe6346a71de28292509L9-L10
Renamed it as credit: c7f0cae#diff-0b17876b36c270997132815de10426dbd0be81130650fbe6346a71de28292509R3
Thank you!
| @@ -0,0 +1 @@ | |||
| python-pptx>=0.6.21 | |||
There was a problem hiding this comment.
Nit: >=0.6.21 is unpinned-up. Fine for now, but if this script runs server-side consider an upper bound — the layout-index constants in build_pptx.py (L_COVER=0 … L_DISCLAIMER=63) are template-version-fragile already.
There was a problem hiding this comment.
Added upper bound of 2.0: c7f0cae#diff-c5ce55c5fa8b1a25d7615616e5ac4d1dc396d3f65b1e98963b7f8a0a89c0369fR1
prasanthlouis
force-pushed
the
feature/moodys-skills
branch
from
c7f0cae to
f1b3692
Compare
2 participants
Adds plugins/partner-built/moodys/ — a new partner plugin that brings Moody's credit data and analytics into the plugin ecosystem.
What's included
5 skills: Earnings Brief, Peer Analysis, Issuer Brief, Rating Analysis, Sector Brief
MCP config: Moody's Credit MCP server (https://api.moodys.com/genai-ready-data/Credit/mcp)
Plugin manifest: .claude-plugin/plugin.json registered in the marketplace
Assets: HTML templates, cover images, a PPTX template, and a Python script for PowerPoint generation