Fix invalid JSON in financial-analysis/.mcp.json (+ validate .mcp.json in check.py)#277
Open
varjoranta wants to merge 2 commits into
Open
Fix invalid JSON in financial-analysis/.mcp.json (+ validate .mcp.json in check.py)#277varjoranta wants to merge 2 commits into
varjoranta wants to merge 2 commits into
Conversation
The core connector config fails to parse (python3 -m json.tool errors at line 47): a missing comma after the `egnyte` entry, and the `box` entry's object left the root object unclosed. Add the comma and close `box` so the file is valid JSON and all 12 connectors load.
check.py validated plugin.json / marketplace.json / steering-examples.json but not .mcp.json, so the malformed connector config slipped through. Add plugins/**/.mcp.json to the JSON-parse globs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
plugins/vertical-plugins/financial-analysis/.mcp.json— the core connector config shared across the suite — is not valid JSON and fails to parse:Two issues at the end of the file: a missing comma after the
egnyteentry, and theboxentry left the top-level object unclosed.Changes
.mcp.json— add the comma and close theboxobject. All 12 connectors parse again:daloopa, morningstar, sp-global, factset, moodys, mtnewswire, aiera, lseg, pitchbook, chronograph, egnyte, box.check.py— it validatedplugin.json/marketplace.json/steering-examples.jsonbut not.mcp.json, so this slipped through. Addedplugins/**/.mcp.jsonto the JSON-parse globs.Verification
Reverting just the
.mcp.jsonfix makes the new check fail as intended: