Map recurring branch-specs gaps so fewer PRs need run-all-specs

[gumclaw]

Round 3: shared components whose consumers span more than one flow escalate.

Checklist

• Scope — mapper-only: FANOUT/config/ignore in bin/branch-specs. Unknown still escalates. Not raising MAX_SELECTED_FILES.
• Design — importer-complete unions only. Shared multi-flow components escalate. Harvest coincidence is not coverage.
• Build — harvest maps, then three adversarial rounds. Round 3 removes incomplete shared-component fanouts.
• QA — ruby spec/bin/branch_specs_test.rb → 99 checks passed. Replay: paypal maps to checkout; RichTextEditor exits 3.
• Shipped — ready for human review. Do not automerge.
• Market — n/a, CI selector.
• Sell — n/a.

What

bin/branch-specs maps a branch diff to the specs CI should run. Exit 3 means the PR must carry run-all-specs. This change teaches it recurring, importer-traced gaps — and refuses to certify a shared component whose consumers span more than one flow.

Why

Sahil, 2026-09-12: "Update run-all-specs based on prior runs to improve it and need it less."

Review rounds

Round 1 claimed 22 of 118 no longer escalate. Astra and Fable BLOCKed: harvest counts were coincidental, not importer-complete.

Round 2 traced importers and reverted boot-global config. Astra still BLOCKed: RichTextEditor's complete union is 157 files (>120), so it must escalate. Same for every shared component whose consumers span more than one flow.

Round 3 principle: stop approximating those fanouts. Do not raise MAX_SELECTED_FILES. Removed: RichTextEditor, TiptapExtensions, ImageUploader, ReviewForm / Review.tsx / ReviewVideoPlayer / data/product_reviews, DateRangePicker, useRecaptcha, data/search.ts, _email.scss. Users/ catch-all replaced with Coffee + Subscribe only (Show and ReviewReminders escalate). Wishlists/Show and Dashboard pages escalate. parsers/profile escalates.

Kept (importer-traced): data/paypal → checkout; Discord button + data; Settings including OAuth, passkeys, and settings_main visitors; EmailsPage + followers; Payouts; Coffee + tipping; articles.yml; Pages and Passwords; DownloadPage including reading/video specs that visit /d/:token; custom_html_analytics including profile_analytics_spec.rb; CONFIG_SPEC_MAP = rack_attack, alterity, instant_ddl_first, active_storage_jobs; docker production nginx/startup/local-compose ignored, test-image inputs escalate.

Honest harvest against origin/main labeled PRs: 12 of 116 no longer escalate (r1 claimed 22 of 118). Three of those 12 are ignored-only docker production files (exit 0, zero specs).

Before → after (origin/main ESCALATE → this head)

PR	After
#7207 RichTextEditor	ESCALATE
#7229 currencies.json	ESCALATE
#7259 DateRangePicker	ESCALATE
#7260 docker/web/server.sh	ignored (0 specs)
#7267 data/search.ts	ESCALATE
#7332 ReviewForm	ESCALATE
#7341 parsers/profile.ts	ESCALATE
#7355 data/paypal.ts	77 checkout specs
#7375 articles.yml	5 specs
#7404 Tiptap + _email.scss	ESCALATE
#7422 config/domain.rb	ESCALATE
#7438 Payouts	16 specs
#7468 docker/nginx	ignored
#7473 Settings PayPalEmailSection	19 specs
#7495 Payouts	36 specs
#7504 custom_html_analytics.ts	46 specs
#7527 docker/nginx	ignored
#7535 TiptapExtensions	ESCALATE
#7578 Emails/Published	6 specs
#7580 Emails/Published	4 specs
#7581 EmailsPage/shared	5 specs
#7589 005_apple.rb	ESCALATE

Post-merge miss #7070 (checkout presenter → checkout/purchases/subscription) is unchanged and pinned.

This PR only touches bin/branch-specs and spec/bin/branch_specs_test.rb, which the selector skips.

Premerge review: clean @ 1856a09

Walkthrough

Terminal recording of ruby spec/bin/branch_specs_test.rb (99 checks) plus selector replay: data/paypal.ts maps to checkout (includes payment_spec, not settings); RichTextEditor.tsx exits 3.

pr7609.mp4

QA

cd <worktree>
ruby spec/bin/branch_specs_test.rb
# 99 checks passed
ruby /tmp/astra-replay.rb paths app/javascript/data/paypal.ts
# status 0, includes spec/requests/checkout/payment_spec.rb
ruby /tmp/astra-replay.rb paths app/javascript/components/RichTextEditor.tsx
# status 3

No user-facing surface.

---

AI disclosure: Grok 4.6. Prompt: harvest run-all-specs PRs, map importer-traced FANOUT gaps, escalate shared multi-flow components, keep MAX_SELECTED_FILES at 120. Round 3: Astra+Fable adversarial passes until SHIP-WITH-FIXES with no P0/P1.

[greptile-apps]

Confidence Score: 4/5

The PR is not yet safe to merge because nested UrlRedirects DownloadPage changes can bypass the intended full-suite escalation, and the repository’s comment rule remains unsatisfied.

Findings

1.  Nested pages skip escalation ▶
2.  Comments retain discovery history ▶

Fix with agent prompt

### Issue 1
bin/branch-specs:192
The `UrlRedirects/DownloadPage` pattern has no path boundary, so it also matches changes to `DownloadPage/Confirm.tsx`, `Stream.tsx`, and `Expired.tsx`. Those changes select only `DOWNLOAD_PAGE_SPECS` even though the adjacent comment says these nested pages must escalate, allowing them to run an incomplete suite.

### Issue 2
bin/branch-specs:150-153
These comments record the harvest date, review round, and `rg` investigation method instead of only the enduring mapping constraints. Similar narration remains in the new test-section comments and names. The repository requires comments to omit historical context and narration of how a change was found, so this requirement must be satisfied before merging.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Summary

• Adds importer-derived spec fan-outs for settings, email, payout, download, profile, help-center, and related flows.
• Narrows Docker ignores to production and local-development inputs.
• Restores escalation for broad config and shared-component changes.
• Adds extensive selector regression coverage.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  Change[Changed path] --> Ignore{Ignored production/local path?}
  Ignore -->|Yes| Skip[Skip spec attribution]
  Ignore -->|No| Escalate{Global or unattributed path?}
  Escalate -->|Yes| Full[Exit 3: full suite required]
  Escalate -->|No| Map[Apply FANOUT, config, and filename mappings]
  Map --> Limit{Selected files exceed limit?}
  Limit -->|Yes| Full
  Limit -->|No| Specs[Run selected specs]

Loading

_{Reviews (2) · Last reviewed commit: "Escalate Users/Show and Dashboard page b..."}