Repository navigation
fix: resolve all reflection warnings - #4
Merged
antlobach merged 1 commit intoOct 14, 2026
Merged
Conversation
->tensor had no return hint, so nearly every op resolved its JavaCPP overload by reflection on each call (~70-100 µs per op on small tensors, ~2 µs after). Enable *warn-on-reflection* in every src namespace, hint all 156 sites, and fail release-check on new warnings. The warnings exposed calls that always threw: max/min with a dim, clip, argsort with a dim, and load-state-dict on native modules; these now work and are covered by tests. Native module forward is looked up once per class and cached, since Module declares no forward.
Contributor
Author
|
I have been running this code in my project for a few weeks and it has been stable, and more performant. |
antlobach
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
->tensor had no return hint, so nearly every op resolved its JavaCPP overload by reflection on each call (~70-100 µs per op on small tensors, ~2 µs after). Enable warn-on-reflection in every src namespace, hint all 156 sites, and fail release-check on new warnings. The warnings exposed calls that always threw: max/min with a dim, clip, argsort with a dim, and load-state-dict on native modules; these now work and are covered by tests. Native module forward is looked up once per class and cached, since Module declares no forward.