[FEAT] Output path as an argument, handle pdf url as NullType - #3
Open
nunofranciscomoreira wants to merge 2 commits into
Open
[FEAT] Output path as an argument, handle pdf url as NullType#3nunofranciscomoreira wants to merge 2 commits into
nunofranciscomoreira wants to merge 2 commits into
Conversation
Allows user to set a different output path besides loot. If none is specified loot will be used.
get_pdf_download_url_for_confluence_cloud may return None, the return value if concatenated without validation, making the script fail. Try is done earlier and now the return value is checked against None.
nunofranciscomoreira
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows user to set a different output path besides loot. If none is specified loot will be used.