Repository navigation
Conversation
… agent module's status Three of the items in #5, the ones that are configuration and documentation. JaCoCo attaches to the same `mvn test` CI already runs and writes one report per module under target/site/jacoco; CI uploads them as an artifact next to the surefire reports. No threshold: the first measurement (core 31 %, driver 46 %, metadata 31 %, web-ui 40 % of lines, Linux, no FAT32) is uneven by history, and a number chosen before looking at it would only block pull requests. TESTING.md records the measurement to compare against. CONTRIBUTING.md says what a change looks like here — one fix per pull request, tests on both sides, the tree left clean by the build, English, no device data — and states the characterization/specification distinction and the KNOWN GAP rule, pointing to TESTING.md and FORMATS.md for the detail rather than repeating them. The agent module's lack of tests was undocumented. It is a decision: a -javaagent instrumenting the Luniistore application's own classes has no behaviour outside a process this project does not ship. TESTING.md now says so. Part of #5 — SpotBugs and JS coverage remain. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This was referenced Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Three of the items in lgnap#5 — the ones that are configuration and documentation, each independent of the others.
Coverage, measured not enforced.
jacoco-maven-plugin0.8.13 in the root pom,prepare-agent+reportbound totest, so it rides the samemvn testCI already runs; one report per module undertarget/site/jacoco/, uploaded by CI asjacoco-reports-<os>next to the surefire reports. No threshold, on purpose: the first measurement (Linux, standard suite, no FAT32 volume) iscoredrivermetadataweb-uiagentlines covered — uneven by history, which the test counts could not show, and a number picked before looking at it would only block pull requests.
TESTING.mdrecords it as the figure to compare against.target/is already ignored, sogit diff --exit-codestays clean.CONTRIBUTING.md. How to run both suites, what a change looks like here (one fix per PR, tests on both sides, the build leaves the tree clean, English, no device data), and the characterization/specification distinction with theKNOWN GAPrule — stated once, pointing toTESTING.mdandFORMATS.mdfor the detail rather than duplicating them. Linked from the README.The
agentmodule's testing status, whichTESTING.mddocumented for every other module and not for this one. It is a decision: a-javaagentthat instruments the Luniistore application's own classes (HttpURLConnection, one of its DTOs) has no behaviour outside a process this project does not ship; a test would mock those classes into meaninglessness or require the Luniistore installed. Written down now.Not in this PR: SpotBugs (the ticket says run it once by hand and triage before deciding on CI — that is its own session) and
--coverageon the JS side.Locally:
mvn -B -Dskip.installnodeyarn=true -Dskip.yarn=true testgreen, four JaCoCo reports produced, tree clean after the build. JaCoCo 0.8.13 runs on Java 11 (CI) through 25 (local).Part of lgnap#5.
🤖 Generated with Claude Code