Skip to content

fix: add missing aria-labels to interactive buttons #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
basantnema31 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: add missing aria-labels to interactive buttons #360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Frontendd/src/components/CoOrganizerPanel.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ export default function CoOrganizerPanel({ eventId, isOwner }) {
onClick={addCoOrg}
disabled={loading || !email}
className="flex items-center gap-1 bg-purple-600 hover:bg-purple-700 text-white px-4 py-2 rounded-lg text-sm font-medium disabled:opacity-50 transition-colors"
>
aria-label="button">
<UserPlus size={15} /> Invite
</button>
</div>
Expand All @@ -80,7 +80,7 @@ export default function CoOrganizerPanel({ eventId, isOwner }) {
<span className="text-gray-400 ml-1">({u.email})</span>
</div>
{isOwner && (
<button onClick={() => removeCoOrg(u._id)} className="text-red-400 hover:text-red-600 ml-2 transition-colors">
<button onClick={() = aria-label="button"> removeCoOrg(u._id)} className="text-red-400 hover:text-red-600 ml-2 transition-colors">
<X size={15} />
</button>
)}
Expand Down
4 changes: 2 additions & 2 deletions Frontendd/src/components/mvpblocks/cta-2.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,11 @@ export default function CTA2() {
</p>

<div className="flex flex-col gap-4 sm:flex-row sm:gap-6">
<button className="flex w-full items-center justify-between rounded-full bg-black px-5 py-3 text-white sm:w-[240px]">
<button className="flex w-full items-center justify-between rounded-full bg-black px-5 py-3 text-white sm:w-[240px]" aria-label="button">
<span className="font-medium">Book a discovery call</span>
<span className="h-5 w-5 flex-shrink-0 rounded-full bg-white"></span>
</button>
<button className="flex w-full items-center justify-between rounded-full bg-black px-5 py-3 text-white sm:w-[240px]">
<button className="flex w-full items-center justify-between rounded-full bg-black px-5 py-3 text-white sm:w-[240px]" aria-label="button">
<span className="font-medium">Test Your Samples</span>
<span className="h-5 w-5 flex-shrink-0 rounded-full bg-white"></span>
</button>
Expand Down
12 changes: 6 additions & 6 deletions Frontendd/src/components/mvpblocks/designer-pricing.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,10 +90,10 @@ export default function DesignerPricing() {
</div>

<div className="mb-8 flex flex-col gap-3">
<button className="bg-primary text-primary-foreground w-full rounded-full px-6 py-3 text-sm font-semibold shadow-sm shadow-primary/20 transition-all duration-200 hover:bg-primary/90">
<button className="bg-primary text-primary-foreground w-full rounded-full px-6 py-3 text-sm font-semibold shadow-sm shadow-primary/20 transition-all duration-200 hover:bg-primary/90" aria-label="button">
Start Creating
</button>
{/* <button className="w-full rounded-full border-2 border-black px-6 py-3 text-sm font-medium text-black transition-all duration-200 hover:bg-black hover:text-white">
{/* <button className="w-full rounded-full border-2 border-black px-6 py-3 text-sm font-medium text-black transition-all duration-200 hover:bg-black hover:text-white" aria-label="button">
Learn More
</button> */}
</div>
Expand Down Expand Up @@ -243,10 +243,10 @@ export default function DesignerPricing() {
</div>

<div className="mb-8 flex flex-col gap-3">
<button className="bg-foreground text-background w-full rounded-full px-6 py-3 text-sm font-semibold shadow-sm shadow-black/20 transition-all duration-200 hover:bg-foreground/90">
<button className="bg-foreground text-background w-full rounded-full px-6 py-3 text-sm font-semibold shadow-sm shadow-black/20 transition-all duration-200 hover:bg-foreground/90" aria-label="button">
Scale Your Brand
</button>
{/* <button className="w-full rounded-full border-2 border-white px-6 py-3 text-sm font-medium text-white transition-all duration-200 hover:bg-white hover:text-black">
{/* <button className="w-full rounded-full border-2 border-white px-6 py-3 text-sm font-medium text-white transition-all duration-200 hover:bg-white hover:text-black" aria-label="button">
Book Demo
</button> */}
</div>
Expand Down Expand Up @@ -418,10 +418,10 @@ export default function DesignerPricing() {
</div>

<div className="mb-8 flex flex-col gap-3">
<button className="bg-foreground text-background w-full rounded-full px-6 py-3 text-sm font-semibold shadow-sm shadow-black/20 transition-all duration-200 hover:bg-foreground/90">
<button className="bg-foreground text-background w-full rounded-full px-6 py-3 text-sm font-semibold shadow-sm shadow-black/20 transition-all duration-200 hover:bg-foreground/90" aria-label="button">
Get Custom Quote
</button>
{/* <button className="w-full rounded-full border-2 border-black px-6 py-3 text-sm font-medium text-black transition-all duration-200 hover:bg-black hover:text-white">
{/* <button className="w-full rounded-full border-2 border-black px-6 py-3 text-sm font-medium text-black transition-all duration-200 hover:bg-black hover:text-white" aria-label="button">
Enterprise Demo
</button> */}
</div>
Expand Down
4 changes: 2 additions & 2 deletions Frontendd/src/components/mvpblocks/faq-3.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ function FAQItem({ question, answer, index }) {
)}>
<button
type="button"
onClick={() => setIsOpen(!isOpen)}
onClick={() = aria-label="button"> setIsOpen(!isOpen)}
className="flex w-full items-center justify-between gap-4 px-6 py-4">
<h3
className={cn(
Expand Down Expand Up @@ -208,7 +208,7 @@ export default function Faq3() {
</p>
<button
type="button"
onClick={() => navigate("/support")}
onClick={() = aria-label="button"> navigate("/support")}
className={cn(
"rounded-md px-4 py-2 text-sm",
"bg-primary text-primary-foreground",
Expand Down
6 changes: 3 additions & 3 deletions Frontendd/src/components/mvpblocks/footer-standard.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ export default function FooterStandard() {
<div className="container m-auto grid grid-cols-1 gap-12 py-12 md:grid-cols-2 lg:grid-cols-5">
{/* Company Info */}
<div className="space-y-6 lg:col-span-2">
<a href="/" className="inline-flex items-center gap-3">
<a href="/" className="inline-flex items-center gap-3" aria-label="link">
<div className="relative">
<div className="flex h-9 w-9 items-center justify-center rounded-xl bg-gradient-to-br from-rose-500 via-rose-600 to-rose-700 shadow-lg">
<Zap className="h-5 w-5 text-white" />
Expand Down Expand Up @@ -124,7 +124,7 @@ export default function FooterStandard() {
asChild
className="hover:bg-primary dark:hover:bg-primary !border-primary/30 cursor-pointer shadow-none transition-all duration-500 hover:scale-110 hover:-rotate-12 hover:text-white hover:shadow-md"
>
<a href={href}>
<a href={href} aria-label="link">
{React.createElement(icon, { className: "h-4 w-4" })}
</a>
</Button>
Expand Down Expand Up @@ -219,7 +219,7 @@ export default function FooterStandard() {
<a
key={label}
href={href}
onClick={(e) => handleLegalClick(e, href)}
onClick={(e) = aria-label="link"> handleLegalClick(e, href)}
className="hover:text-rose-600 transition-colors cursor-pointer"
>
{label}
Expand Down
4 changes: 2 additions & 2 deletions Frontendd/src/components/mvpblocks/header-2.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,7 @@ export default function Header2() {
<div className="border-t border-border/50 my-1" />

<button
onClick={() => {
onClick={() = aria-label="button"> {
setIsProfileMenuOpen(false);
logout(navigate);
}}
Expand Down Expand Up @@ -469,7 +469,7 @@ export default function Header2() {
<span>Dashboard</span>
</Link>
<button
onClick={() => {
onClick={() = aria-label="button"> {
setIsMobileMenuOpen(false);
logout(navigate);
}}
Expand Down
4 changes: 2 additions & 2 deletions Frontendd/src/components/ui/NotificationBell.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ export default function NotificationBell() {
return (
<div className="relative" ref={dropdownRef}>
<button
onClick={() => setIsDropdownOpen(!isDropdownOpen)}
onClick={() = aria-label="button"> setIsDropdownOpen(!isDropdownOpen)}
className="relative p-2 text-foreground/80 hover:text-foreground transition-colors rounded-full hover:bg-muted/50"
aria-label="Notifications"
>
Expand All @@ -154,7 +154,7 @@ export default function NotificationBell() {
? 'text-muted-foreground cursor-not-allowed opacity-50'
: 'text-indigo-500 hover:text-indigo-600'
}`}
>
aria-label="button">
<CheckCircle2 className="h-3 w-3" />
Mark all as read
</button>
Expand Down
2 changes: 1 addition & 1 deletion Frontendd/src/components/ui/ScrollToTop.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ const ScrollToTop = () => {
<button
onClick={scrollToTop}
className="fixed bottom-5 right-5 bg-black text-white px-4 py-2 rounded-full shadow-lg hover:bg-gray-800 transition-all duration-300 z-50"
>
aria-label="button">
<FaArrowUp />
</button>
)}
Expand Down
4 changes: 2 additions & 2 deletions Frontendd/src/components/ui/confirmation-modal.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ const ConfirmationModal = ({
<button
onClick={onClose}
className="px-4 py-2 rounded-lg border border-gray-300 hover:bg-gray-100 transition"
>
aria-label="Close">
Cancel
</button>

Expand All @@ -35,7 +35,7 @@ const ConfirmationModal = ({
<button
onClick={onConfirm}
className="px-4 py-2 rounded-lg bg-red-500 text-white hover:bg-red-600 transition"
>
aria-label="button">
Confirm
</button>
) : (null)
Expand Down
4 changes: 2 additions & 2 deletions Frontendd/src/pages/ForgotPassword.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ export default function ForgotPassword() {
<button
type="button"
className="text-xs text-white/70 hover:text-white transition-colors"
onClick={() => setToast(null)}
onClick={() = aria-label="button"> setToast(null)}
>
Dismiss
</button>
Expand Down Expand Up @@ -148,7 +148,7 @@ export default function ForgotPassword() {
type="submit"
disabled={isSubmitting}
className="w-full mt-6 py-3.5 px-4 bg-gradient-to-r from-[#e63946] to-[#d62839] hover:from-[#d62839] hover:to-[#c1121f] text-white font-semibold rounded-lg transition-all duration-300 disabled:opacity-50 disabled:cursor-not-allowed shadow-lg shadow-red-600/20 hover:shadow-red-600/30 transform hover:-translate-y-0.5"
>
aria-label="Submit">
{isSubmitting ? (
<div className="flex items-center justify-center space-x-2">
<div className="w-5 h-5 border-2 border-white/30 border-t-white rounded-full animate-spin" />
Expand Down
6 changes: 3 additions & 3 deletions Frontendd/src/pages/SignIn.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ const handleSubmit = async (e) => {
>
{/* Close Button */}
<button
onClick={() => navigate(-1)}
onClick={() = aria-label="button"> navigate(-1)}
className="absolute top-4 right-4 w-8 h-8 flex items-center justify-center rounded-full bg-zinc-800 hover:bg-zinc-700 text-gray-400 hover:text-white transition-all duration-200 z-20"
type="button">
✕
Expand Down Expand Up @@ -129,7 +129,7 @@ const handleSubmit = async (e) => {
className="absolute right-3 top-1/2 -translate-y-1/2 text-gray-500 hover:text-gray-900 transition-colors p-1"
type="button"
onClick={toggleVisibility}
>
aria-label="button">
{isVisible ? (
<Eye className="h-5 w-5" />
) : (
Expand All @@ -153,7 +153,7 @@ const handleSubmit = async (e) => {
type="submit"
disabled={isLoading}
className="w-full mt-8 py-3.5 px-4 bg-gradient-to-r from-[#e63946] to-[#d62839] hover:from-[#d62839] hover:to-[#c1121f] text-white font-semibold rounded-lg transition-all duration-300 disabled:opacity-50 disabled:cursor-not-allowed shadow-lg shadow-red-600/20 hover:shadow-red-600/30 transform hover:-translate-y-0.5"
>
aria-label="Submit">
{isLoading ? (
<div className="flex items-center justify-center space-x-2">
<div className="w-5 h-5 border-2 border-white/30 border-t-white rounded-full animate-spin" />
Expand Down
10 changes: 5 additions & 5 deletions Frontendd/src/pages/SignUp.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ export default function SignUp() {
>
{/* Close Button */}
<button
onClick={() => navigate(-1)}
onClick={() = aria-label="button"> navigate(-1)}
className="absolute top-4 right-4 w-8 h-8 flex items-center justify-center rounded-full bg-zinc-800 hover:bg-zinc-700 text-gray-400 hover:text-white transition-all duration-200 z-20"
type="button">
✕
Expand Down Expand Up @@ -249,7 +249,7 @@ export default function SignUp() {
className="absolute right-3 top-1/2 -translate-y-1/2 text-gray-500 hover:text-gray-900 transition-colors p-1"
type="button"
onClick={toggleVisibility}
>
aria-label="button">
{isVisible ? <Eye className="h-5 w-5" /> : <EyeOff className="h-5 w-5" />}
</button>
</div>
Expand All @@ -275,7 +275,7 @@ export default function SignUp() {
className="absolute right-3 top-1/2 -translate-y-1/2 text-gray-500 hover:text-gray-900 transition-colors p-1"
type="button"
onClick={toggleConfirmVisibility}
>
aria-label="button">
{isConfirmVisible ? <Eye className="h-5 w-5" /> : <EyeOff className="h-5 w-5" />}
</button>
</div>
Expand All @@ -295,7 +295,7 @@ export default function SignUp() {
I agree to the{" "}
<button
type="button"
onClick={(e) => {
onClick={(e) = aria-label="button"> {
e.preventDefault();
setActiveModal('terms');
}}
Expand All @@ -311,7 +311,7 @@ export default function SignUp() {
type="submit"
disabled={!isFormValid || isLoading}
className="w-full mt-8 py-3.5 px-4 bg-gradient-to-r from-[#e63946] to-[#d62839] hover:from-[#d62839] hover:to-[#c1121f] text-white font-semibold rounded-lg transition-all duration-300 disabled:opacity-50 disabled:cursor-not-allowed shadow-lg shadow-red-600/20 hover:shadow-red-600/30 transform hover:-translate-y-0.5"
>
aria-label="Submit">
{isLoading ? (
<div className="flex items-center justify-center space-x-2">
<div className="w-5 h-5 border-2 border-white/30 border-t-white rounded-full animate-spin" />
Expand Down
8 changes: 4 additions & 4 deletions Frontendd/src/pages/dashboard/AdminDashboard.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,7 +377,7 @@ export default function AdminDashboard() {
{['Pending Reviews', 'All Events & Management', 'User Management'].map((tab) => (
<button
key={tab}
onClick={() => setActiveTab(tab)}
onClick={() = aria-label="button"> setActiveTab(tab)}
className={`pb-4 text-sm font-medium transition-colors relative whitespace-nowrap ${activeTab === tab
? 'text-orange-500' // Orange text
: 'text-muted-foreground hover:text-foreground'
Expand Down Expand Up @@ -762,7 +762,7 @@ export default function AdminDashboard() {
<p className="text-zinc-500 text-sm mt-1">This reason will be applied to all {selectedCount} selected event{selectedCount > 1 ? 's' : ''}.</p>
</div>
<button
onClick={() => {
onClick={() = aria-label="button"> {
if (bulkLoading) return;
setBulkRejectOpen(false);
setBulkRejectReason('');
Expand Down Expand Up @@ -829,7 +829,7 @@ export default function AdminDashboard() {
<h3 className="text-2xl font-bold text-zinc-900">{selectedEvent.title}</h3>
<p className="text-zinc-500 text-sm mt-1">{selectedEvent.organizer?.name}</p>
</div>
<button onClick={() => setSelectedEvent(null)} className="text-zinc-400 hover:text-zinc-900">
<button onClick={() = aria-label="button"> setSelectedEvent(null)} className="text-zinc-400 hover:text-zinc-900">
<X className="w-5 h-5" />
</button>
</div>
Expand Down Expand Up @@ -899,7 +899,7 @@ export default function AdminDashboard() {
<p className="text-zinc-500 text-sm mt-1">{rejectingEvent.title}</p>
</div>
<button
onClick={() => {
onClick={() = aria-label="button"> {
if (rejectLoading) return;
setRejectingEvent(null);
setRejectReason('');
Expand Down
2 changes: 1 addition & 1 deletion Frontendd/src/pages/dashboard/CreateEvent.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,7 +363,7 @@ const removeTag = (tagToRemove) => {

<button
type="button"
onClick={() =>
onClick={() = aria-label="button">
removeTag(tag)
}
className="text-xs hover:text-red-500"
Expand Down
Loading
Loading