chore: Miscellaneous fixes and improvements - #284
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
BGEM3 assertions are overly permissive, and release output serialization remains vulnerable to delimiter collisions.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Improves test reliability, sparse embedding processing, documentation, and workflow security.
Changes:
- Adjusts embedding tolerances and BGEM3 test locking.
- Refines sparse allocations and weight parsing.
- Adds explicit workflow permissions and safer release-author output handling.
File summaries
| File | Description |
|---|---|
tests/text-embeddings.rs |
Widens embedding comparison tolerance. |
tests/bgem3.rs |
Updates tolerances and poisoned-lock handling. |
src/sparse_text_embedding/impl.rs |
Corrects sparse-vector allocation capacity. |
src/sparse_text_embedding/bgem3_weights.rs |
Validates weight-byte chunking. |
src/common.rs |
Corrects documentation punctuation. |
.github/workflows/test.yml |
Restricts test-job permissions. |
.github/workflows/release.yml |
Adds release permissions and multiline outputs. |
Review details
- Files reviewed: 7/7 changed files
- Comments generated: 2
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
github-actions Bot
pushed a commit
that referenced
this pull request
Aug 27, 2026
## [6.0.2](https://github.com/[secure]008/fastembed-rs/compare/v6.0.1...v6.0.2) (2026-08-27) ### 🧹 Chores * Miscellaneous fixes and improvements ([#284](https://github.com/[secure]008/fastembed-rs/issues/284)) ([397e8d0](https://github.com/[secure]008/fastembed-rs/commit/397e8d0c35b2ca04b3b87139a5256f20413b879b))
|
🎉 This PR is included in version 6.0.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.