Skip to content

Tony/525 profile picture#538

Open
tonypioneer wants to merge 5 commits intodevfrom
tony/525_profile_picture
Open

Tony/525 profile picture#538
tonypioneer wants to merge 5 commits intodevfrom
tony/525_profile_picture

Conversation

@tonypioneer
Copy link
Copy Markdown
Collaborator

Pull Request Details

Description

Allow users to upload and remove the profile photo.

Related Issues

#525

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How To Test?

Build and run the app.

Checklist

  • Screenshots included in linked issue Implement Profile Picture Upload #525
  • Changes adhere to the style and coding guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules
  • The update contains no confidential information
  • The update has no duplicated content
  • No lint check errors are related to these changes (make prep or flutter analyze lib)
  • Integration test dart test output or screenshot included in issue #
  • I tested the PR on these devices:
    • Android
    • iOS
    • Linux
    • MacOS
    • Windows
    • Web
  • I have identified reviewers
  • The PR has been approved by reviewers

Finalising

  • Merge dev into the this branch
  • Resolve any conflicts
  • Add a one line summary into the CHANGELOG.md
  • Push to the git repository and review
  • Merge the PR into dev

@tonypioneer tonypioneer requested a review from gjwgit March 11, 2026 11:35
@tonypioneer tonypioneer linked an issue Mar 11, 2026 that may be closed by this pull request
4 tasks
Copy link
Copy Markdown
Collaborator

@gjwgit gjwgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested. works well. However on restarting the app I get:

Image

@tonypioneer tonypioneer requested a review from gjwgit March 12, 2026 11:49
@tonypioneer
Copy link
Copy Markdown
Collaborator Author

tonypioneer commented Mar 12, 2026

Hi @gjwgit, this issue has been fixed.

This issue occurs because when the application starts, initialiseProfileData calls saveResponseToPod to create or update the profile data. After a user uploads an avatar and restarts the app, if the user has only uploaded a profile avatar but has not created the profile data, or if the user closes the security key pop-up after restarting, writePod will fail during the encrypted write operation, which results in an exception being thrown.

Copy link
Copy Markdown
Collaborator

@gjwgit gjwgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After I update the profile picture, the old picture remains visible whereas I expected it to be updated.

It is updated to the new image on a restart.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement Profile Picture Upload

2 participants