Skip to content

Tony/264 appbar pref overflow #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jesscmoore merged 4 commits into from
Apr 15, 2026
Merged

Tony/264 appbar pref overflow #389

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cd1af12
Fix the overflow issues
tonypioneer Apr 5, 2026
bddae2a
Merge branch 'dev' of https://github.com/anusii/notepod into tony/264…
tonypioneer Apr 8, 2026
ae47e53
Use the new SolidScaffoldHelpers to fix the overflow in the selected/…
tonypioneer Apr 14, 2026
4db1d11
Lint
tonypioneer Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
104 changes: 59 additions & 45 deletions lib/notes/list_notes.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,8 +115,11 @@ class _ListNotesState extends State<ListNotes> {
/// cards to display note items
late double cardAspectRatio = 2.0;

/// Boolean describing whether window is narrow
/// Screen width category flags derived from SolidScaffoldHelpers.
late bool isVeryNarrow;
late bool isNarrow;
late bool isWide;
late bool isVeryWide;

@override
void initState() {
Expand Down Expand Up @@ -371,8 +374,14 @@ class _ListNotesState extends State<ListNotes> {

return LayoutBuilder(
builder: (context, constraints) {
// Derive whether window is narrow
isNarrow = WindowSize().isNarrowWindow(constraints);
isVeryNarrow = SolidScaffoldHelpers.isVeryNarrowScreen(constraints);
isNarrow = SolidScaffoldHelpers.isNarrowScreen(constraints);
isWide = SolidScaffoldHelpers.isWideScreen(constraints);
isVeryWide = SolidScaffoldHelpers.isVeryWideScreen(constraints);
// debugPrint(
// 'isVeryNarrow: $isVeryNarrow, isNarrow: $isNarrow, isWide: $isWide, isVeryWide: $isVeryWide',
// );

// Calculate the aspect radio for grid cards
cardAspectRatio = NoteItemSize().calculateCardAspectRatio(constraints);
return SizedBox(
Expand Down Expand Up @@ -407,29 +416,34 @@ class _ListNotesState extends State<ListNotes> {
children: [
// Count statement
// Match color scheme of sorting TextButtons
selectedCount > 0
? Text(
'Selected: $selectedCount notes',
style: TextStyle(
color: theme.colorScheme.primary,
),
)
: _foundNotes.length > 1 || _foundNotes.isEmpty
? Text(
'Found ${_foundNotes.length} notes',
style: TextStyle(
color: theme.colorScheme.primary,
),
)
: Text(
'Found ${_foundNotes.length} note',
style: TextStyle(
color: theme.colorScheme.primary,
),
Flexible(
child: selectedCount > 0
Comment thread
tonypioneer marked this conversation as resolved.
? Text(
'Selected: $selectedCount notes',
style: TextStyle(
color: theme.colorScheme.primary,
),
overflow: TextOverflow.ellipsis,
)
: _foundNotes.length > 1 || _foundNotes.isEmpty
? Text(
'Found ${_foundNotes.length} notes',
style: TextStyle(
color: theme.colorScheme.primary,
),
overflow: TextOverflow.ellipsis,
)
: Text(
'Found ${_foundNotes.length} note',
style: TextStyle(
color: theme.colorScheme.primary,
),
overflow: TextOverflow.ellipsis,
),
),
Row(
mainAxisAlignment: MainAxisAlignment.end,
spacing: (!isNarrow) ? 3.0 : 0,
spacing: (!isVeryNarrow) ? 3.0 : 0,
children: [
// Multiple note delete button
// Only display multi note delete
Expand All @@ -449,7 +463,7 @@ class _ListNotesState extends State<ListNotes> {
isExtFileSelected: _isExtFileSelected,
),
],
// Title Sort Label and Button
// Title sort — always visible.
TextButton.icon(
onPressed: () {
_sortByTitle(!_sortTitleAscending);
Expand All @@ -464,25 +478,26 @@ class _ListNotesState extends State<ListNotes> {
),
iconAlignment: IconAlignment.end,
),
// Date Sort Label and Button
TextButton.icon(
onPressed: () {
_sortByModDate(!_sortModDateAscending);
},
icon: Icon(
_sortModDateAscending
? Icons.arrow_drop_down
: Icons.arrow_drop_up,
),
label: Text(
(!isNarrow) ? 'Date Modified' : 'Date',
// Date sort — hidden on very narrow screens
// to prevent overflow.
if (!isVeryNarrow) ...[
TextButton.icon(
onPressed: () {
_sortByModDate(!_sortModDateAscending);
},
icon: Icon(
_sortModDateAscending
? Icons.arrow_drop_down
: Icons.arrow_drop_up,
),
label: Text(
isNarrow ? 'Date' : 'Date Modified',
),
iconAlignment: IconAlignment.end,
),
iconAlignment: IconAlignment.end,
),
// Filename Sort Label and Button
// Only display filename sort
// when window is not narrow
if (!isNarrow) ...[
],
// Filename sort — only on medium or wider screens.
if (!isVeryNarrow && !isNarrow) ...[
TextButton.icon(
onPressed: () {
_sortByFilename(!_sortFilenameAscending);
Expand Down Expand Up @@ -596,15 +611,14 @@ class _ListNotesState extends State<ListNotes> {
.contains('read'))
? Text(
_foundNotes[index].content!.noteTitle,
maxLines:
(!isNarrow) ? 1 : 3, // Limit lines
maxLines: (!isVeryNarrow) ? 1 : 3,
overflow: TextOverflow.ellipsis,
)
: const Text(''),
// Note item subtitle
subtitle: NoteItemSubtitle(
note: _foundNotes[index],
isNarrow: isNarrow,
isNarrow: isVeryNarrow,
),
// Define width to avoid consuming full width
trailing: SizedBox(
Expand Down
Loading