Emit proposed plans for plan-capable clients#4
Draft
s-cork wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
plan_updateevents when the client advertises Plan supportRationale
agentclientprotocol/codex-acp#326 fixed plan visibility by emitting completed plans as ordinary final-answer messages. That preserves broad client compatibility, but loses the plan semantic: capable clients cannot distinguish a proposed plan from a normal final answer or render it as a first-class plan artifact.
This change preserves that fallback while emitting
plan_updateonly when the client advertises Plan support, including during session replay.The main review points are capability gating and parity between live events and loaded session history.
Testing
npm run typechecknpx vitest run src/__tests__/CodexACPAgent/load-session.test.ts— includes legacy replay without Plan capabilitynpm test— 329 passed, 28 skippednpm run bundle:allwith Bun 1.3.11git diff --check main...HEADRelated work
AI assisted with implementation, test verification, and PR text.