Expose rate limits on usage updates#5
Draft
s-cork wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
usage_updateevents under_meta["_codex/rateLimits"]Rationale
codex-acpalready stores account rate-limit snapshots for status reporting, but ACP clients cannot consume them. Namespaced metadata exposes the same snapshots without changing the standard ACP usage fields.Rate-limit notifications are sparse: nullable fields mean unavailable, not cleared. Merging them with the last known snapshot prevents rolling updates from erasing windows, credits, plan metadata, or spend-control state.
The main review points are the extension shape, event timing, sparse-update merging, and accumulation of multiple independently identified rate limits.
Testing
npm run typechecknpm test— 331 passed, 28 skippednpm run bundle:allwith Bun 1.3.11git diff --check main...HEADTests cover deferred emission when a rate-limit notification arrives first, immediate refresh after usage is known, and complete-to-sparse updates that omit the ID or name.
Related work
AI assisted with implementation, test refinement, verification, and PR text.