Adds Focus to all Interactable components#340
Open
Duncanr-glitch wants to merge 15 commits into
Open
Conversation
…ownMenu and _Components.IconButton
…omponents.NavigationLink and 1 more
…Components.Slider and 1 more
daviesian
force-pushed
the
master
branch
6 times, most recently
from
February 4, 2026 13:54
481c80a to
e84db02
Compare
Collaborator
|
Hi @Duncanr-glitch! Thank you for your contributions! This PR addresses several issues, and also adds a lot of changes that are not necessary for those issues. In order for me to better review and accept the changes, it would be helpful if you could:
For testing, I'd recommend using a separate testing app that depends on your forked M3 app. That way, you don't have to add Testing Forms to the theme. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements and Resolves #336 by adding a focus method to every component that can be interacted with.
Several minor bug fixes involving focus and/or keyboard interaction:
Fixes #337
Fixes #338
Fixes #339