Repository navigation
test: the starved-pool tests no longer depend on timing - #108
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The flake:
a_starved_pool_answers_429_with_retry_after_within_the_acquire_timeoutfailed on Windows withleft: 429, right: 200fromReply::ok(200), not from the assertion about the starved pool. The test builds a cloud with a two-connection pool and a 500 ms acquire timeout and then signs up through the API. On a slow runner the cloud's own background work (sweep, heartbeat) holds a connection while the sign-up needs one, so the sign-up itself was answered 429. The earlier fix (#103) only made the check after the release patient.Now every test of this file does its setup patiently (
until_servedasks again while the answer is 429,sign_upuses it) andholdtakes the whole pool, waiting for the background work to give connections back. From then on the pool is empty by the test's own doing. All assertions are unchanged (429 withrate_limited,Retry-Afterof 1 to 2 s, timing bounds, 503 for the request timeout, the shed and health tests).Need help on this PR? Tag
@codesmith-botwith what you need.