Repository navigation
test: fix two flakes that red docs-only PRs (played_with minimum time, e2e sign-up) - #112
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both seen on cloud#111 (first attempt of ci run 40618693556).
postgres:
played_with::a_pair_is_remembered_only_after_the_minimum_time(left 0, right 1 at line 156).sweep_played_withis throttled by a node-wide atomic: the first caller to compare-exchange it runsrecord, every other caller returns at once. The test resets the atomic to 0 and callssweep, but the cloud's own background sweep loop can win the exchange in between; the test's call then returns early while the backgroundrecordis still writing, and the list is read empty. The test now repeats reset + sweep until the pair shows (10 s limit).windows: three e2e tests,
Email ... failed: rate_limited "Too many requests"at sign-up. The limiter is per cloud state, so tests cannot share one. The same wording is what a saturated store answers (a pool or SQLite write-turn wait pastdatabase_acquire_timeout_ms, 5 s, is mapped to 429 "rate_limited" so clients retry). Six e2e tests with relays run in parallel on the Windows runner; the first calls wait past 5 s. The e2e clouds now use a 60 s acquire timeout. Production limits and defaults are unchanged. (The warn log of the busy store is not captured in CI, so the cause is inferred from the code path, not seen directly.)Need help on this PR? Tag
@codesmith-botwith what you need.