Skip to content

Account web: who sees my leaderboard scores (Scores row on the Privacy page, six languages) - #51

Merged
AlxcBTW merged 5 commits into
mainfrom
night/score-privacy-row
Oct 28, 2026
Merged

AlxcBTW merged 5 commits into
mainfrom
night/score-privacy-row

Conversation

@AlxcBTW

@AlxcBTW AlxcBTW commented Oct 28, 2026 •

Copy link
Copy Markdown
Member

A "Scores" card on the account web's Privacy page: who sees my leaderboard scores (gap G12 in the cloud's data inventory). The cloud half is GET/PUT /v1/me/score-privacy ({scores: friends|everyone|nobody}, friends for a new account).

  • API client: account.scorePrivacy() and setScorePrivacy(value), separate from Privacy like appear offline and the public profile; HTTP adapter and mock (with the nosave scenario), unit tests for both.
  • Screen: ScoresCard on /account/privacy, same optimistic save with rollback and the reason on failure, a loading placeholder, a retry on a failed load. The group stays enabled while saving, so the arrow keys keep working. One line under the choice says what it means for the current choice (friends, everyone including people who are not signed in with handle, score and date on the board's public page, nobody) and is announced as it changes; the radio group points at it with aria-describedby. Wording follows the privacy notice in Privacy notice: leaderboard scores #50.
  • Six languages: EN, TR, DE, ES, FR, PT (account.privacy.scores), the audience words are the existing ones.
  • Tests: e2e (desktop and phone, axe) for the default, everyone, keyboard and a failed save; messages parity test covers the new keys.
  • Review round: it blocked on one static sentence that misstated the current choice and on the missing announcement; both fixed. Not done here on purpose: the shared audience picker's touch targets (about 31 px high, on every picker of the page), which is a change of its own.
  • Also adds the missing bundle budget for /boards/[title]/[board] (merged before the budget check existed; main's CI would otherwise fail on it).

The privacy notice (#50) still says the launcher and this website show no setting for the scores. Once this merges, that sentence must say that the setting is on this website, under Privacy in the account.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@AlxcBTW
AlxcBTW merged commit b8e1bf6 into main Oct 28, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant