Repository navigation
Account web: who sees my leaderboard scores (Scores row on the Privacy page, six languages) - #51
Merged
Merged
Conversation
…ds, everyone, nobody), in six languages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A "Scores" card on the account web's Privacy page: who sees my leaderboard scores (gap G12 in the cloud's data inventory). The cloud half is
GET/PUT /v1/me/score-privacy({scores: friends|everyone|nobody}, friends for a new account).account.scorePrivacy()andsetScorePrivacy(value), separate fromPrivacylike appear offline and the public profile; HTTP adapter and mock (with thenosavescenario), unit tests for both.ScoresCardon/account/privacy, same optimistic save with rollback and the reason on failure, a loading placeholder, a retry on a failed load. The group stays enabled while saving, so the arrow keys keep working. One line under the choice says what it means for the current choice (friends, everyone including people who are not signed in with handle, score and date on the board's public page, nobody) and is announced as it changes; the radio group points at it witharia-describedby. Wording follows the privacy notice in Privacy notice: leaderboard scores #50.account.privacy.scores), the audience words are the existing ones./boards/[title]/[board](merged before the budget check existed; main's CI would otherwise fail on it).The privacy notice (#50) still says the launcher and this website show no setting for the scores. Once this merges, that sentence must say that the setting is on this website, under Privacy in the account.
Need help on this PR? Tag
@codesmith-botwith what you need.