Repository navigation
CI: Playwright projects on two runners side by side (speed plan, step 11) - #53
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 11 of the speed plan. The Dockerfile part (lockfile first, pnpm store cache mount) is already on main (#37). This splits the e2e job into one runner per Playwright project (phone, desktop);
e2estays as the aggregate check name the ruleset requires.Measured (ubuntu-latest): e2e was 411 s (run 40621694249) and 360 s (run 40620846545); now the slower shard is 274 s (run 40648101536; phone 236 s, desktop 274 s) plus 4 s aggregate. Saves about 90 to 135 s per PR.