[SOL] Fix version detection in call lowering - #214
Open
nathan-osec wants to merge 1 commit into
Open
Conversation
|
There… should be tests that change here; and if there aren't please add a test with one commit showing initial state and the diff to the test along with the fix commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
LowerCallmethod usesgetHasDynamicFramesto distinguish between SBPFv0 and v3 when it should be usinggetHasNoStackGaps. This causes a redundantmov64 r5, r10instruction to be emitted for every SBPFv3 call with more than 5 arguments, even though it can be optimized out if optimization is enabled.